Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Bigtable factories and shell classes. #1229

Merged

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Nov 19, 2015

The Cluster, Table, Row and ColumnFamily classes (and modules) are introduced, but without any functionality except for other nested factories.

@dhermes dhermes added the api: bigtable Issues related to the Bigtable API. label Nov 19, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2015
"latin-1", which which will only allows byte ordinals
(up to 255) and "utf-8", which will encode any unicode
that needs to be.

This comment was marked as spam.

This comment was marked as spam.

The Cluster, Table, Row and ColumnFamily classes (and
modules) are introduced, but without any functionality
except for other nested factories.
@dhermes dhermes force-pushed the bigtable-add-factories-and-shell-classes branch from a7172ad to 2547f84 Compare November 19, 2015 20:39
@dhermes
Copy link
Contributor Author

dhermes commented Nov 19, 2015

@tseaver I moved it into gcloud._helpers. Anything else blocking this PR?

@tseaver
Copy link
Contributor

tseaver commented Nov 19, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Nov 19, 2015

Coveralls having load problems. Merging before it passes.

dhermes added a commit that referenced this pull request Nov 19, 2015
…l-classes

Adding Bigtable factories and shell classes.
@dhermes dhermes merged commit 0773f5c into googleapis:master Nov 19, 2015
@dhermes dhermes deleted the bigtable-add-factories-and-shell-classes branch November 19, 2015 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants