Skip to content

Fixes #3150 - Ignores resource key when it isn't present #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2017
Merged

Fixes #3150 - Ignores resource key when it isn't present #3177

merged 3 commits into from
Mar 21, 2017

Conversation

lucmult
Copy link
Contributor

@lucmult lucmult commented Mar 21, 2017

  • The new test fails with the KeyError experienced by customer.
  • Tests passing on Python 2.7 and 3.4 (I don't have 3.5 on my env).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2017
lukesneeringer
lukesneeringer suggested changes Mar 21, 2017
View reviewed changes
Copy link
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading #3150, am I correct that the resource key is guaranteed to be present if api_response['done'] is truthy? If so, we should move the _set_properties call into the if block rather than have the permissive try-except.

@lukesneeringer
Copy link
Contributor

I just confirmed that and made the change I suggested, now tossing to @dhermes for review.

CI will still fail until #3178 is merged, so it will have to go in before this can.

@lukesneeringer lukesneeringer requested a review from dhermes March 21, 2017 15:10
@lukesneeringer lukesneeringer self-assigned this Mar 21, 2017
@lukesneeringer
Copy link
Contributor

I merged in master (which includes #3178), merging once CI passes.

@lukesneeringer lukesneeringer merged commit 486163e into googleapis:master Mar 21, 2017
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
@lucmult @lukesneeringer
Fixes googleapis#3150 - Ignores resource key when it isn't present (g…
4a422f3 
…oogleapis#3177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes Awaiting requested review from dhermes

2 more reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lukesneeringer lukesneeringer

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucmult @lukesneeringer @tseaver @googlebot