Skip to content

Flesh out pubsub subscriptions #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 19, 2015
Merged

Flesh out pubsub subscriptions #743

merged 8 commits into from
Mar 19, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 18, 2015

Uses #742 as a base.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 18, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2015
@tseaver tseaver changed the title Flesh out pubsub subscription Flesh out pubsub subscriptions Mar 18, 2015
This was referenced Mar 18, 2015
Closed
Merged
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2015

@tseaver I'm going to hold off on this until #742 is through. Is that OK or do you prefer otherwise?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 18, 2015

Holding off here is fine.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c64c0f2 on tseaver:691-flesh_out_pubsub_subscription into aa684be on GoogleCloudPlatform:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 1d08a87 on tseaver:691-flesh_out_pubsub_subscription into aa684be on GoogleCloudPlatform:master.

tseaver added 2 commits March 19, 2015 13:27
@tseaver
Add 'pubsub.subscription.Subscription' class.
7799622 
Include 'create', 'delete', 'exists', and 'reload' method to manage
subscription state.

Allow toggling between push / pull w/ 'modify_push_config'.

Consume / acknowledge messages in pull-mode w/ 'pull', 'acknowledge',
and 'modify_ack_deadline'.
@tseaver
Add 'pubsub.api.list_subscriptions'.
42b0dc3
@tseaver
Copy link
Contributor Author

tseaver commented Mar 19, 2015

@dhermes rebased after merge of #742.

dhermes
dhermes reviewed Mar 19, 2015
View reviewed changes
gcloud/pubsub/api.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 19, 2015

LGTM though you should get sign off from @tmatsuo to make sure you are making the correct API calls

tmatsuo
tmatsuo reviewed Mar 19, 2015
View reviewed changes
gcloud/pubsub/api.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tmatsuo
Copy link
Contributor

tmatsuo commented Mar 19, 2015

Left few comments, but LGTM in terms of the correctness of API paths and methods.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ea1625c on tseaver:691-flesh_out_pubsub_subscription into 01d697e on GoogleCloudPlatform:master.

tmatsuo
tmatsuo reviewed Mar 19, 2015
View reviewed changes
gcloud/pubsub/subscription.py Outdated

This comment was marked as spam.

Sign in to view

@tmatsuo
Copy link
Contributor

tmatsuo commented Mar 19, 2015

still LGTM

tseaver added a commit that referenced this pull request Mar 19, 2015
@tseaver
Merge pull request #743 from tseaver/691-flesh_out_pubsub_subscription
85dc64b 
Flesh out pubsub subscriptions
@tseaver tseaver merged commit 85dc64b into googleapis:master Mar 19, 2015
@tseaver tseaver deleted the 691-flesh_out_pubsub_subscription branch March 19, 2015 20:05
@dhermes dhermes mentioned this pull request Apr 9, 2015
Merged
parthea pushed a commit that referenced this pull request Aug 21, 2025
@gcf-owl-bot
fix: fix ValueError in test__validate_universe_domain (#743)
f51ccd6 
* fix: fix `ValueError` in `test__validate_universe_domain`

PiperOrigin-RevId: 604699565

Source-Link: googleapis/googleapis@cd3eabf

Source-Link: googleapis/googleapis-gen@01f69ba
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDFmNjliYTdhMTNkNTllNmY0NWUyNDMzNTliOTFhNmU4OTYyMjFmOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@gcf-owl-bot @parthea
fix: fix ValueError in test__validate_universe_domain (#743)
cae2678 
* fix: fix `ValueError` in `test__validate_universe_domain`

PiperOrigin-RevId: 604699565

Source-Link: googleapis/googleapis@cd3eabf

Source-Link: googleapis/googleapis-gen@01f69ba
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDFmNjliYTdhMTNkNTllNmY0NWUyNDMzNTliOTFhNmU4OTYyMjFmOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
@renovate-bot
chore(deps): update all dependencies (#743)
7dda6db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tseaver @dhermes @coveralls @tmatsuo @googlebot