Flesh out pubsub subscriptions by tseaver · Pull Request #743 · googleapis/google-cloud-python

tseaver · 2015-03-18T19:09:31Z

Uses #742 as a base.

dhermes · 2015-03-18T20:28:16Z

@tseaver I'm going to hold off on this until #742 is through. Is that OK or do you prefer otherwise?

tseaver · 2015-03-18T20:41:17Z

Holding off here is fine.

coveralls · 2015-03-18T22:53:29Z

Coverage remained the same at 100.0% when pulling c64c0f2 on tseaver:691-flesh_out_pubsub_subscription into aa684be on GoogleCloudPlatform:master.

coveralls · 2015-03-19T01:25:54Z

Coverage remained the same at 100.0% when pulling 1d08a87 on tseaver:691-flesh_out_pubsub_subscription into aa684be on GoogleCloudPlatform:master.

Include 'create', 'delete', 'exists', and 'reload' method to manage subscription state. Allow toggling between push / pull w/ 'modify_push_config'. Consume / acknowledge messages in pull-mode w/ 'pull', 'acknowledge', and 'modify_ack_deadline'.

tseaver · 2015-03-19T17:29:18Z

@dhermes rebased after merge of #742.

gcloud/pubsub/api.py

dhermes · 2015-03-19T17:47:56Z

LGTM though you should get sign off from @tmatsuo to make sure you are making the correct API calls

gcloud/pubsub/api.py

tmatsuo · 2015-03-19T18:07:45Z

Left few comments, but LGTM in terms of the correctness of API paths and methods.

Addresses: #743 (comment)

Addresses: #743 (comment).

Addresses: #743 (comment)

coveralls · 2015-03-19T19:13:30Z

Coverage remained the same at 100.0% when pulling ea1625c on tseaver:691-flesh_out_pubsub_subscription into 01d697e on GoogleCloudPlatform:master.

gcloud/pubsub/subscription.py

tmatsuo · 2015-03-19T19:40:20Z

still LGTM

[ci skip]

Flesh out pubsub subscriptions

* fix: fix `ValueError` in `test__validate_universe_domain` PiperOrigin-RevId: 604699565 Source-Link: googleapis/googleapis@cd3eabf Source-Link: googleapis/googleapis-gen@01f69ba Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDFmNjliYTdhMTNkNTllNmY0NWUyNDMzNTliOTFhNmU4OTYyMjFmOCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This reverts commit 3c698679e544df571ed5e181db29b2d55eafbe2b.

Co-authored-by: google-cloud-policy-bot[bot] <80869356+google-cloud-policy-bot[bot]@users.noreply.github.com>

tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 18, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2015

tseaver changed the title ~~Flesh out pubsub subscription~~ Flesh out pubsub subscriptions Mar 18, 2015

This was referenced Mar 18, 2015

Initial pubsub implementation plan #744

Closed

Flesh out pubsub topics #742

Merged

tseaver added 2 commits March 19, 2015 13:27

Add 'pubsub.api.list_subscriptions'.

42b0dc3

dhermes reviewed Mar 19, 2015
View reviewed changes

gcloud/pubsub/api.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tmatsuo reviewed Mar 19, 2015
View reviewed changes

gcloud/pubsub/api.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 5 commits March 19, 2015 14:09

Link to API docs for 'list_topics'/'list_subscriptions'.

db75350

Addresses: #743 (comment)

Spell out ACK.

bdcc60b

Addresses: #743 (comment).

Document param to 'modify_push_configuration'.

e1b581d

Addresses: #743 (comment)

Fix docstring for 'Subscription.refresh'.

6a9eb19

Addresses: #743 (comment)

Fix docstring for 'Subscription.modify_ack_deadline'.

ea1625c

Addresses: #743 (comment)

tmatsuo reviewed Mar 19, 2015
View reviewed changes

gcloud/pubsub/subscription.py Outdated

This comment was marked as spam.

Sign in to view

Docstring typo fixes per @tmatsuo.

7821d88

[ci skip]

tseaver added a commit that referenced this pull request Mar 19, 2015

Merge pull request #743 from tseaver/691-flesh_out_pubsub_subscription

85dc64b

Flesh out pubsub subscriptions

tseaver merged commit 85dc64b into googleapis:master Mar 19, 2015

tseaver deleted the 691-flesh_out_pubsub_subscription branch March 19, 2015 20:05

dhermes mentioned this pull request Apr 9, 2015

Upgrading version to 0.5.0. #813

Merged

parthea pushed a commit that referenced this pull request Sep 18, 2025

chore(deps): update all dependencies (#743)

7dda6db

parthea pushed a commit that referenced this pull request Nov 22, 2025

chore(deps): update dependency pytest to v7.2.2 (#743)

359d9ea

parthea added a commit that referenced this pull request Nov 24, 2025

chore: Revert "chore: move retry async check to wrap time (#668)" (#743)

ab1d30f

This reverts commit 3c698679e544df571ed5e181db29b2d55eafbe2b.

parthea pushed a commit that referenced this pull request Nov 26, 2025

chore: add SECURITY.md (#743)

905a40d

Co-authored-by: google-cloud-policy-bot[bot] <80869356+google-cloud-policy-bot[bot]@users.noreply.github.com>

Conversation

tseaver commented Mar 18, 2015

Uh oh!

dhermes commented Mar 18, 2015

Uh oh!

tseaver commented Mar 18, 2015

Uh oh!

coveralls commented Mar 18, 2015

Uh oh!

coveralls commented Mar 19, 2015

Uh oh!

tseaver commented Mar 19, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Mar 19, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tmatsuo commented Mar 19, 2015

Uh oh!

coveralls commented Mar 19, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

tmatsuo commented Mar 19, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants