Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bigquery): update code samples of load table file and uri #10175

Merged
merged 4 commits into from
Feb 3, 2020
Merged

refactor(bigquery): update code samples of load table file and uri #10175

merged 4 commits into from
Feb 3, 2020

Conversation

HemangChothani
Copy link
Contributor

Towards #8989

List of changes:

  1. load_table_file
  2. load_table_uri_avro
  3. load_table_uri_csv
  4. load_table_uri_json
  5. load_table_uri_parquet
  6. load_table_uri_orc
  7. load_table_uri_cmek

@HemangChothani HemangChothani requested review from tswast and a team January 21, 2020 12:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 21, 2020
shollyman
shollyman approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments before submitting. Thanks.

bigquery/docs/usage/tables.rst Outdated
@@ -110,6 +110,28 @@ Load a Parquet file from Cloud Storage:
See also: `Loading Parquet data from Cloud Storage
<https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-parquet>`_.

Load a Avro file from Cloud Storage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/a Avro/an Avro/

bigquery/docs/usage/tables.rst Outdated
See also: `Loading Avro data from Cloud Storage
<https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-avro>`_.

Load a ORC file from Cloud Storage:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/a Orc/an Orc/

bigquery/samples/load_table_file.py Outdated
@@ -0,0 +1,43 @@
# Copyright 2019 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update copyright notices to 2020 in the new files

@HemangChothani
Copy link
Contributor Author

test_client_load_partitioned_table snippet failed is unrelated to changes.

@tswast tswast mentioned this pull request Jan 24, 2020
Merged
@HemangChothani HemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2020
@plamut plamut added the api: bigquery Issues related to the BigQuery API. label Jan 31, 2020
@plamut
Copy link
Contributor

plamut commented Feb 3, 2020

Merging, as the PR has been approved, and the comments in the approval have been addressed.

@plamut plamut merged commit 10dd74a into googleapis:master Feb 3, 2020
This was referenced Feb 4, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Feb 5, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HemangChothani @plamut @shollyman @googlebot @yoshi-kokoro