Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling datastore renames key -> keys #1456

Merged
merged 2 commits into from
Feb 12, 2016
Merged

Handling datastore renames key -> keys #1456

merged 2 commits into from
Feb 12, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Feb 12, 2016

A repeated Key field occurs on:

  • AllocateIdsResponse
  • AllocateIdsRequest
  • LookupRequest

Was #1358

@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Feb 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 12, 2016
@dhermes dhermes mentioned this pull request Feb 12, 2016
Closed
49 tasks
@theacodes
Copy link
Contributor

LGTM

(I had reviewed this, but never actually send the response)

@dhermes
Copy link
Contributor Author

dhermes commented Feb 12, 2016

Thanks!

dhermes added a commit that referenced this pull request Feb 12, 2016
@dhermes
Merge pull request #1456 from dhermes/handle-key-keys-rename-1288-2
c799a56 
Handling datastore renames key -> keys
@dhermes dhermes merged commit c799a56 into googleapis:datastore-v1beta3 Feb 12, 2016
@dhermes dhermes deleted the handle-key-keys-rename-1288-2 branch February 12, 2016 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@theacodes theacodes

Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @theacodes @googlebot