Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have travis-ci run tox -e cover to catch code branch coverage misses #1872

Closed
daspecster opened this issue Jun 20, 2016 · 8 comments
Closed

Have travis-ci run tox -e cover to catch code branch coverage misses #1872

daspecster opened this issue Jun 20, 2016 · 8 comments
Assignees
@daspecster

Comments

@daspecster
Copy link
Contributor

As is turns out, coveralls doesn't cover code branch misses very well.
We could have travis run tox -e cover to ensure that we have proper code coverage before publishing it to coveralls.
@daspecster daspecster mentioned this issue Jun 20, 2016
Merged
@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016 •
edited
Loading

There is a coveralls.io build target as well

@daspecster
Copy link
Contributor Author

It could go in there.
I was just thinking it made sense in the .travis.yml as part of the build process.

I'm good either way though.

daspecster added a commit to daspecster/google-cloud-python that referenced this issue Jun 20, 2016
@daspecster
Add tox cover task to travis build. closes googleapis#1872
fdec3a1
@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016

The point is that every PR already has a coverage check

@daspecster
Copy link
Contributor Author

I think the issue is coveralls.io says that there's 100% coverage but tox -e cover says there's 99% coverage due to #1870 (comment)

@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016

WAT! That sucks. Let's figure out what's wrong with coveralls.io instead of doing double duty. Do you need to be added as an admin?

@daspecster
Copy link
Contributor Author

The sad truth appears to be here my friend lemurheavy/coveralls-public#31

@daspecster daspecster mentioned this issue Jun 20, 2016
Closed
@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016

Ouch. Based on that, let's switch to codecov.io?

daspecster added a commit to daspecster/google-cloud-python that referenced this issue Jun 20, 2016
@daspecster
Switch to codecov.io closes googleapis#1872
261111f
@daspecster
Copy link
Contributor Author

Looks promising!
#1876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daspecster daspecster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daspecster @dhermes