Adding list zones request to Bigtable client. #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| """Async method meant to mock a gRPC stub request.""" | ||
| self._factory.method_calls.append((self._name, args, kwargs)) | ||
| curr_result = self._factory.results[0] | ||
| self._factory.results = self._factory.results[1:] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
force-pushed
the
bigtable-list-zones
branch
from
a8ac571
to
0dc78cf
Compare
Also adding test helper for faking behavior from gRPC stubs.
dhermes
force-pushed
the
bigtable-list-zones
branch
from
0dc78cf
to
9c18dad
Compare
|
@tseaver Override removed. PTAL. |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Nov 19, 2015
Adding list zones request to Bigtable client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding test helper for faking behavior from gRPC stubs.