Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cyclic imports or just stop worrying and love the bomb #517

Closed
dhermes opened this issue Jan 8, 2015 · 0 comments · Fixed by #522
Closed

Remove cyclic imports or just stop worrying and love the bomb #517

dhermes opened this issue Jan 8, 2015 · 0 comments · Fixed by #522
Assignees
@dhermes
Labels
api: datastore Issues related to the Datastore API.

Comments

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

See #477 for context.

Relevant code and pylint config.
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Jan 8, 2015
@dhermes dhermes mentioned this issue Jan 8, 2015
Closed
9 tasks
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 8, 2015
@dhermes
Removing Key.get() and Entity.reload().
81397ea 
Removed Entity.reload() because it relied on the existence
of Key.get(). Replacing it would have required import
gcloud.datastore.get in entity.py, which would have again
been a cyclic import.

With an eye on removing the Entity class (see googleapis#490),
removing Entity.reload() is not such a big deal.

Fixes googleapis#517.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 8, 2015
@dhermes
Removing Key.get() and Entity.reload().
9600c11 
Removed Entity.reload() because it relied on the existence
of Key.get(). Replacing it would have required import
gcloud.datastore.get in entity.py, which would have again
been a cyclic import.

With an eye on removing the Entity class (see googleapis#490),
removing Entity.reload() is not such a big deal.

Fixes googleapis#517.
@dhermes dhermes mentioned this issue Jan 8, 2015
Merged
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 8, 2015
@dhermes
Removing Key.get() and Entity.reload().
1b152ee 
Removed Entity.reload() because it relied on the existence
of Key.get(). Replacing it would have required import
gcloud.datastore.get in entity.py, which would have again
been a cyclic import.

With an eye on removing the Entity class (see googleapis#490),
removing Entity.reload() is not such a big deal.

Fixes googleapis#517.
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 8, 2015
@dhermes
Removing Key.get() and Entity.reload().
6d351a5 
Removed Entity.reload() because it relied on the existence
of Key.get(). Replacing it would have required import
gcloud.datastore.get in entity.py, which would have again
been a cyclic import.

With an eye on removing the Entity class (see googleapis#490),
removing Entity.reload() is not such a big deal.

Fixes googleapis#517.
@dhermes dhermes mentioned this issue Jan 13, 2015
Closed
@jgeewax jgeewax modified the milestone: Datastore Stable Jan 30, 2015
parthea pushed a commit that referenced this issue Aug 15, 2023
@gcf-owl-bot
docs: minor formatting changes (#517)
d3c2e64 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Update the copyright year
docs: Reformat some lines of code

PiperOrigin-RevId: 518686790

Source-Link: googleapis/googleapis@2205f23

Source-Link: googleapis/googleapis-gen@0b041ff
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIwNDFmZjJiZTJkMWFkMzAxMGVmMzUxYTVkNjJiNmQyYTFjOGEzYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@yoshi-automation @busunkim96
feat: add support for streaming automl action recognition in v1p3beta…
75c6c3a 
…1; make 'features' a positional param for annotate_video in betas (#31)

* Integrate Python GAPIC Microgenerator in googleapis.
This PR uses using documentai as an example.
Depends on googleapis/gapic-generator-python#402

PiperOrigin-RevId: 309824146

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 4 15:06:44 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e0f9d9e1f9de890db765be46f45ca8490723e3eb
Source-Link: googleapis/googleapis@e0f9d9e

* chore(python): create thread_safety doc (#517)

This will be included in index.rst files. See https://github.com/googleapis/python-bigtable/pull/26/files

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 5 10:06:52 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 09c48461232ce929c34386259eb59018ad2d8eef
Source-Link: googleapis/synthtool@09c4846

* chore(python): remove extra #!/bin/bash (#538)

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Tue May 12 09:51:12 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 7482e79a82e353248769d819788adc1213e8c207
Source-Link: googleapis/synthtool@7482e79

* chore!: enable gapicv2 for monitoring/v3 API

This introduces the following breakages upon code regeneration, which are due to the `TimeSeriesQueryLanguageCondition` type being removed from `alert.proto` in a preceding change.

```
[ERROR] 6011: com.google.monitoring.v3.AlertPolicy$Condition: Field CONDITION_TIME_SERIES_QUERY_LANGUAGE_FIELD_NUMBER has been removed, but it was previously a constant
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder clearConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder getConditionTimeSeriesQueryLanguageBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder mergeConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition)' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$Condition$Builder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$Builder setConditionTimeSeriesQueryLanguage(com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder)' has been removed
[ERROR] 6001: com.google.monitoring.v3.AlertPolicy$Condition$ConditionCase: Removed field CONDITION_TIME_SERIES_QUERY_LANGUAGE
[ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition removed
[ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition$Builder removed
[ERROR] 8001: com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder: Class com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageCondition getConditionTimeSeriesQueryLanguage()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public com.google.monitoring.v3.AlertPolicy$Condition$TimeSeriesQueryLanguageConditionOrBuilder getConditionTimeSeriesQueryLanguageOrBuilder()' has been removed
[ERROR] 7002: com.google.monitoring.v3.AlertPolicy$ConditionOrBuilder: Method 'public boolean hasConditionTimeSeriesQueryLanguage()' has been removed
```

Committer: @miraleung
PiperOrigin-RevId: 311581003

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 14 12:13:51 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 123873dc7e2be35252d172205f67a375e70e9747
Source-Link: googleapis/googleapis@123873d

* fix: restore GAPIC v2 retry configs

Restores GAPIC v2 retry config overrides that were
mistakenly removed during migration.

PiperOrigin-RevId: 312088359

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 18 08:57:12 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 5a90d467aa65e7f038f87585e8fbb45d74475e7c
Source-Link: googleapis/googleapis@5a90d46

* feat(v1p3beta1): added support for streaming automl action recognition.

PiperOrigin-RevId: 312101156

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 18 10:04:40 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: d1a9f02fd4fb263bae0383b4a5af0bbef33753d6
Source-Link: googleapis/googleapis@d1a9f02

* fix: point artman at gapic v1 for monitoring/v3 API

Committer: @miraleung
PiperOrigin-RevId: 312104480

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 18 10:19:39 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: e94ad376529fabdfd2fce00407926a0cefd38b9e
Source-Link: googleapis/googleapis@e94ad37

* Dialogflow weekly v2 library update:
- Minor comment updates.

PiperOrigin-RevId: 312123588

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon May 18 11:49:18 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: cd3ce2651c3921670217e664303976cdf76e9fe2
Source-Link: googleapis/googleapis@cd3ce26

* chore(python): remove one remaining extra bash line (#565)

To avoid generating bogus PRs

Co-authored-by: Jeffrey Rennie <rennie@google.com>

Source-Author: Carlos de la Guardia <cguardia@yahoo.com>
Source-Date: Tue May 19 11:57:19 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: d2364eb80b840a36136c8ce12f1c6efabcc9600e
Source-Link: googleapis/synthtool@d2364eb

* Upgrade protoc-docs-plugin version to 0.7.0 to fix unstable docstrings.

PiperOrigin-RevId: 312689208

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu May 21 10:00:47 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: dec3204175104cef49bf21d685d5517caaf0058f
Source-Link: googleapis/googleapis@dec3204

* bazel: update protobuf, rules_go, gazelle, and gapic-generator-go versions
- protobuf v3.12.1
- rules_go v0.23.0
- gazelle v0.21.0
- gapic-generator-go v0.14.1

PiperOrigin-RevId: 313460921

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 27 14:10:16 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: c4e37010d74071851ff24121f522e802231ac86e
Source-Link: googleapis/googleapis@c4e3701

* Use correct resource type for DetachSubscriptionRequest

PiperOrigin-RevId: 313488995

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed May 27 16:45:32 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: eafa840ceec23b44a5c21670288107c661252711
Source-Link: googleapis/googleapis@eafa840

* docs: update python docs template (#576)

* docs: update python docs template

* sphinx change

Source-Author: kolea2 <45548808+kolea2@users.noreply.github.com>
Source-Date: Wed May 27 20:44:34 2020 -0400
Source-Repo: googleapis/synthtool
Source-Sha: 71b8a272549c06b5768d00fa48d3ae990e871bec
Source-Link: googleapis/synthtool@71b8a27

* feat: add templates for python samples projects (#506)

These templates will be used for templates in python-docs-samples
and in Python client libraries. The README generation code is a modified
version of
https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/scripts/readme-gen.

Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:39:58 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ffe10407ee2f261c799fb0d01bf32a8abc67ed1e
Source-Link: googleapis/synthtool@ffe1040

* chore: update default ignores for Python libraries (#586)

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 14:43:37 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: e99975b6b49827b8720f0a885e218dbdb67849ca
Source-Link: googleapis/synthtool@e99975b

* feat: allow custom python versions in noxfile (#585)

Libraries on the microgenerator support a smaller range of Python versions (3.6+).

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Thu May 28 18:22:04 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4e1d2cb79b02d7496b1452f91c518630c207145e
Source-Link: googleapis/synthtool@4e1d2cb

* docs: fix docs

Co-authored-by: Bu Sun Kim <busunkim@google.com>
parthea added a commit that referenced this issue Oct 21, 2023
@renovate-bot @parthea
chore(deps): update all dependencies (#517)
48f04e4 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.8.4 (#517)
b5c0509 
* chore: Update gapic-generator-python to v1.8.4

PiperOrigin-RevId: 507808936

Source-Link: googleapis/googleapis@64cf849

Source-Link: googleapis/googleapis-gen@53c48ca
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
build(deps): bump requests from 2.28.1 to 2.31.0 in /synthtool/gcp/te…
1a7fe8b 
…mplates/python_library/.kokoro (#517)

Source-Link: googleapis/synthtool@30bd01b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Key.get() and Entity.reload() dhermes/google-cloud-python
2 participants
@jgeewax @dhermes