Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should 'topics.testIamPermissions' be wrapped as 'check_iam_permissions'? #1648

Closed
tseaver opened this issue Mar 22, 2016 · 1 comment
Closed

Should 'topics.testIamPermissions' be wrapped as 'check_iam_permissions'? #1648

tseaver opened this issue Mar 22, 2016 · 1 comment
Assignees
@tseaver
Labels
api: pubsub Issues related to the Pub/Sub API. type: question Request for information or clarification. Not an issue.

Comments

@tseaver
Copy link
Contributor

tseaver commented Mar 22, 2016

See: #1642 (comment) and ff.

Likewise subscriptions.testIamPermission.

@jgeewax if you decide so, please assign the issue to me; otherwise, just close it.
@tseaver tseaver added type: question Request for information or clarification. Not an issue. api: pubsub Issues related to the Pub/Sub API. labels Mar 22, 2016
This was referenced Mar 22, 2016
Merged
Merged
@jgeewax
Copy link
Contributor

jgeewax commented Mar 23, 2016

I'm a fan of check unless we have an awesome reason not to...

@tseaver tseaver assigned tseaver and unassigned jgeewax Mar 23, 2016
@tseaver tseaver mentioned this issue Mar 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: pubsub Issues related to the Pub/Sub API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgeewax @tseaver