Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

dhermes · 2014-12-23T02:45:43Z

Addresses fifth part of #451.

NOTE: This has #460 as a diffbase.

coveralls · 2014-12-23T02:48:18Z

Coverage remained the same when pulling 64ab5ee on dhermes:fix-451-part5 into b343acf on GoogleCloudPlatform:master.

tseaver · 2014-12-30T15:52:25Z

64ab5ee Maybe finalize as a name, instead of complete_key? Kind of fits with is_partial, too.

LGTM either way.

dhermes · 2014-12-30T17:45:16Z

I worry that would indicate that it wasn't already final, which it sort of is by being immutable.

coveralls · 2014-12-30T17:52:25Z

Coverage remained the same when pulling 1442143 on dhermes:fix-451-part5 into 8cb41f6 on GoogleCloudPlatform:master.

tseaver · 2014-12-31T21:12:01Z

Do we need to change is_final then?

Other than that, LGTM.

Addresses fifth part of googleapis#451.

dhermes · 2014-12-31T21:14:21Z

Does is_final exist? Here in complete_key, complete is the verb, not the adjective. But the ambiguity means it may be better to find another word.

coveralls · 2014-12-31T21:15:08Z

Coverage remained the same when pulling 33d546d on dhermes:fix-451-part5 into 74e6c16 on GoogleCloudPlatform:master.

dhermes · 2014-12-31T21:18:18Z

Since it is a method on Key, the _key is a bit redunant. @tseaver WDYT about Key.make_complete?

tseaver · 2014-12-31T21:22:29Z

I was misremembering 'is_partial' as 'is_final'. How about 'completed_key', since it returns a new instance (if needed).

tseaver · 2014-12-31T21:22:56Z

Or even 'complete_from_pb'?

dhermes · 2014-12-31T21:24:06Z

completed SGTM. It's not being completed from a pb. Will rewrite and ping you after new commit.

dhermes · 2014-12-31T21:29:01Z

1df085e pushed

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys.

coveralls · 2014-12-31T21:30:37Z

Coverage remained the same when pulling 1df085e on dhermes:fix-451-part5 into 74e6c16 on GoogleCloudPlatform:master.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ve] (#461) Source-Link: https://togithub.com/googleapis/synthtool/commit/6ed3a831cb9ff69ef8a504c353e098ec0192ad93 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* fix(deps): require google-api-core>=1.32.0,>=2.8.0 * chore: update constraints

* chore: update to gapic-generator-python 1.5.0 feat: add support for `google.cloud.<api>.__version__` PiperOrigin-RevId: 484665853 Source-Link: googleapis/googleapis@8eb249a Source-Link: googleapis/googleapis-gen@c8aa327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update version in gapic_version.py * chore: Update to gapic-generator-python 1.6.0 feat(python): Add typing to proto.Message based class attributes feat(python): Snippetgen handling of repeated enum field PiperOrigin-RevId: 487326846 Source-Link: googleapis/googleapis@da380c7 Source-Link: googleapis/googleapis-gen@61ef576 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: fix minor docstring formatting PiperOrigin-RevId: 493589316 Source-Link: googleapis/googleapis@02e3850 Source-Link: googleapis/googleapis-gen@ab49dcf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWI0OWRjZjU2MDhlNzE1OWQwN2Y1M2JkODg4Zjk3ZDIwOTIwMzVlNyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use templated owlbot.py and autogenerated setup.py * configure release please to use manifest Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * require proto-plus 1.22.2 for python 3.11 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

dhermes mentioned this pull request Dec 23, 2014

Update Key API to be more user-friendly per design doc discussion #451

Closed

10 tasks

dhermes mentioned this pull request Dec 23, 2014

Address sixth part of 451: Implement Key.compare_to_proto to check pb keys against existing. #462

Merged

dhermes force-pushed the fix-451-part5 branch from 64ab5ee to 1442143 Compare December 30, 2014 17:49

Implement Key.complete_key for auto_id on partial keys.

33d546d

Addresses fifth part of googleapis#451.

dhermes force-pushed the fix-451-part5 branch from 1442143 to 33d546d Compare December 31, 2014 21:13

Renaming Key.complete_key to completed_key.

1df085e

tseaver added a commit that referenced this pull request Dec 31, 2014

Merge pull request #461 from dhermes/fix-451-part5

f0e26b8

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys.

tseaver merged commit f0e26b8 into googleapis:master Dec 31, 2014

dhermes deleted the fix-451-part5 branch December 31, 2014 21:31

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore(main): release 2.17.0 (#461)

59f30ef

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(main): release 2.17.0 (#461)

ef727b9

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(main): release 2.17.0 (#461)

2d16f4f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(main): release 2.17.0 (#461)

7785e49

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-auth to v2.11.0 (#461)

9e37296

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): require google-api-core>=1.32.0,>=2.8.0 (#461)

eda63e3

* fix(deps): require google-api-core>=1.32.0,>=2.8.0 * chore: update constraints

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 2.17.0 (#461)

b721305

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

Uh oh!

dhermes commented Dec 23, 2014

Uh oh!

coveralls commented Dec 23, 2014

Uh oh!

tseaver commented Dec 30, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

coveralls commented Dec 30, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

coveralls commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

coveralls commented Dec 31, 2014

Uh oh!

Uh oh!

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

Uh oh!

Conversation

dhermes commented Dec 23, 2014

Uh oh!

coveralls commented Dec 23, 2014

Uh oh!

tseaver commented Dec 30, 2014

Uh oh!

dhermes commented Dec 30, 2014

Uh oh!

coveralls commented Dec 30, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

coveralls commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

tseaver commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

dhermes commented Dec 31, 2014

Uh oh!

coveralls commented Dec 31, 2014

Uh oh!

Uh oh!