-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Removing use of pytz module / implementing our own UTC. #1044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
No problem with this one overall. I wonder if our local |
|
@tseaver RE: default to using Code reviews are so useful 😄 I totally overlooked that and it's totally the right way to go. |
|
I figured that dropping |
|
Yeah for sure. |
790e798 to
b8bce16
Compare
|
@tseaver I re-pushed the initial commit. Sorry I finished it awhile ago but forgot to push. Wanted to actually test the case that |
|
We could add a |
|
What is that? |
|
Oops, I inverted it in my mind: we could add a stanza that tests it w/ [testenv:py27_w_extras]
deps =
{[testenv]deps}
pytz |
|
Can we punt on it for this PR and |
|
Sure. The only thing I see which might be gating is we have no explicit test coverage for the |
|
I added it to |
|
LGTM |
Removing use of pytz module / implementing our own UTC.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
🤖 I have created a release \*beep\* \*boop\* --- ## [0.54.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.53.4...v0.54.0) (2021-10-29) ### Features * generate code snippets by default ([#1044](https://www.github.com/googleapis/gapic-generator-python/issues/1044)) ([e46f443](https://www.github.com/googleapis/gapic-generator-python/commit/e46f443dbeffe16b63f97668801b06189769e972)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Enable snippetgen for the default (non-Ads) templates. This reverts commit 8bdb70931a9ecb1c89fda9608697b0762770bc12 (which was a revert of #1044 and #1055). I've checked that the changes are OK (don't break generation for any APIs) by creating a [tag](https://github.com/googleapis/gapic-generator-python/commits/v0.62.0b1) and running the [presubmit](https://critique.corp.google.com/cl/424921742).
* feat: add experimental GDCH support * use ec key * update comment * Update google/oauth2/gdch_credentials.py * fix * add project, update payload
This was inspired by #1009.
Our methods for signing strings with credentials / crypto will likely be moved into
oauth2client, so this is a pre-emptive move to avoid havingpytzas a dependency foroauth2client.As an added benefit, we avoid having
pytzas a dependency, which helps for people wanting to usegcloud-pythonon App Engine./cc @nathanielmanistaatgoogle