Fix #313: Add Key properties #349

tseaver · 2014-11-06T17:41:07Z

Builds on #347, and presumes it is already merged: only 0e6c5bd, 89e31be, and a7b997b are unique to this branch.

Notes:

Some Key properties (e.g., etag, owner) have the same name and one-liner implementation as those in Bucket: this PR keeps them separate because their docstrings differ (they contain URLs pointing to the relevant API spec documents).
metadata is restored (for Key only) as the spec uses it: a mapping of arbitrary, application specific data.

coveralls · 2014-11-06T17:51:35Z

Coverage remained the same when pulling a7b997b on tseaver:313-key_properties into 01a1eea on GoogleCloudPlatform:master.

coveralls · 2014-11-06T22:46:33Z

Changes Unknown when pulling 8770d80 on tseaver:313-key_properties into * on GoogleCloudPlatform:master*.

tseaver · 2014-11-06T22:47:06Z

@dhermes this one is more straightforward, given that #347 did all the re-factoring.

gcloud/storage/bucket.py

@@ -501,8 +499,6 @@ def metageneration(self):
        See: https://cloud.google.com/storage/docs/json_api/v1/buckets

        :rtype: integer
-        :returns: count of times since creation the bucket's metadata has


Addresses part of #313.

Addresses part of #314.

coveralls · 2014-11-07T01:33:59Z

Changes Unknown when pulling fce864c on tseaver:313-key_properties into * on GoogleCloudPlatform:master*.

tseaver · 2014-11-07T01:35:15Z

@dhermes all green. I can rebase if needed.

dhermes · 2014-11-07T01:36:56Z

@tseaver Can you implement the simple property factory for "DRY" purpose?

tseaver · 2014-11-07T02:01:42Z

@dhermes did that in 9605a00

dhermes · 2014-11-07T02:02:36Z

My bad, I think I had a really old cache of the page in my tab. Looking now.

gcloud/storage/key.py

+    """
+    def _getter(self):
+        """Scalar property getter.
+        """


Sigh. That is *never* gonna look right to me.

coveralls · 2014-11-07T02:28:49Z

Changes Unknown when pulling a915447 on tseaver:313-key_properties into * on GoogleCloudPlatform:master*.

dhermes · 2014-11-07T02:36:47Z

LGTM

Fix #313: Add Key properties

Source-Link: googleapis/synthtool@06e8279 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…349) Source-Link: googleapis/synthtool@6b4d5a6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f792ee1320e03eda2d13a5281a2989f7ed8a9e50b73ef6da97fac7e1e850b149 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc

* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * trigger CI Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

fix(deps): require proto-plus >= 1.22.0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.7.1](https://www.github.com/googleapis/python-dialogflow/compare/v2.7.0...v2.7.1) (2021-07-26) ### Bug Fixes * enable self signed jwt for grpc ([#345](https://www.github.com/googleapis/python-dialogflow/issues/345)) ([ae434ed](https://www.github.com/googleapis/python-dialogflow/commit/ae434edc46c5e9c3243b928674727ea91cdf0145)) ### Documentation * fix typos ([#347](https://www.github.com/googleapis/python-dialogflow/issues/347)) ([1aa9a7a](https://www.github.com/googleapis/python-dialogflow/commit/1aa9a7a67d2997d87735666ecdcc55c8f8442cdf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…p/templates/python_library/.kokoro (#349) * build(deps): bump cryptography from 38.0.3 to 39.0.1 in /synthtool/gcp/templates/python_library/.kokoro Source-Link: googleapis/synthtool@bb17135 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f62c53736eccb0c4934a3ea9316e0d57696bb49c1a7c86c726e9bb8a2f87dadf * trigger ci --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(deps): update dependency google-cloud-dataproc to v3.3.0 * remove pin for python 3.6 Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b

Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py * feat: add LRS API PiperOrigin-RevId: 493338018 Source-Link: googleapis/googleapis@380b2f0 Source-Link: googleapis/googleapis-gen@5802e4b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTgwMmU0YmQyNDRmMTFhYmY4OGM4ZWUzOTY4ZGMxZDcyODFjNDk2YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add LRS API PiperOrigin-RevId: 493606501 Source-Link: googleapis/googleapis@a1b5429 Source-Link: googleapis/googleapis-gen@ea4e780 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWE0ZTc4MDJiN2RhN2RiM2EyZjQyMmE1ZGJmNGUzZjRmOGM2MDY3ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * docs: fix minor docstring formatting PiperOrigin-RevId: 495308712 Source-Link: googleapis/googleapis@45c90e2 Source-Link: googleapis/googleapis-gen@61828bb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjE4MjhiYmRjZjAwYWVhYmZlZDNmNTVlZDBmOWNiNTI1MmVmOWQ0NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* fix(deps): Require google-api-core >=1.34.0, >=2.11.0 fix: Drop usage of pkg_resources fix: Fix timeout default values docs(samples): Snippetgen should call await on the operation coroutine before calling result PiperOrigin-RevId: 493260409 Source-Link: googleapis/googleapis@fea4387 Source-Link: googleapis/googleapis-gen@387b734 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add gapic_version.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@82f5cb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@f15cc72 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd

Source-Link: googleapis/synthtool@82f5cb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@06e8279 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce

tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. api: storage Issues related to the Cloud Storage API. labels Nov 6, 2014

tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 6, 2014

dhermes reviewed Nov 6, 2014
View reviewed changes

tseaver added 5 commits November 6, 2014 20:33

Avoid re-iterating summary line.

e8c4391

Add accessors for read-only properties of a server-side object.

bafe213

Addresses part of #313.

Add writable 'Key' properties matching writable server-side properties.

2b26990

Addresses part of #314.

Factor out simple scalar property creation using helper methods.

520de84

Docstrings.

f8d8844

dhermes reviewed Nov 7, 2014
View reviewed changes

gcloud/storage/key.py

"""

def _getter(self):

"""Scalar property getter.

"""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

One-line docstrings.

a915447

Sigh. That is *never* gonna look right to me.

tseaver added a commit that referenced this pull request Nov 7, 2014

Merge pull request #349 from tseaver/313-key_properties

8cd4c5e

Fix #313: Add Key properties

tseaver merged commit 8cd4c5e into googleapis:master Nov 7, 2014

tseaver deleted the 313-key_properties branch November 7, 2014 02:47

tseaver mentioned this pull request Nov 7, 2014

Add __getitem__ support to connections and buckets #63

Closed

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.5.0 (#349)

7ea1ed0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-crc32c to v1.5.0 (#349)

59792b8

parthea added a commit that referenced this pull request Jul 6, 2023

fix(deps): allow protobuf < 5.0.0 (#349)

8e0f584

fix(deps): require proto-plus >= 1.22.0

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(main): release 1.10.1 (#349)

766c716

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Sep 22, 2023

fix(deps): require protobuf <4.0.0dev (#349)

8dfc835

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 1.11.0 (#349)

bb637a8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: use python-samples-reviewers (#349)

44c140c

parthea pushed a commit that referenced this pull request Oct 21, 2023

docs(samples): Fixing an issue with listing all instances (#349)

f0b0def

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-kms to v2.12.2 (#349)

6800e47

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.3.2 (#349)

5f7b235

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-auth to v2.13.0 (#349)

2e7ef70

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #313: Add Key properties #349

Fix #313: Add Key properties #349

tseaver commented Nov 6, 2014

coveralls commented Nov 6, 2014

coveralls commented Nov 6, 2014

tseaver commented Nov 6, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 7, 2014

tseaver commented Nov 7, 2014

dhermes commented Nov 7, 2014

tseaver commented Nov 7, 2014

dhermes commented Nov 7, 2014

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 7, 2014

dhermes commented Nov 7, 2014

Fix #313: Add Key properties #349

Fix #313: Add Key properties #349

Conversation

tseaver commented Nov 6, 2014

coveralls commented Nov 6, 2014

coveralls commented Nov 6, 2014

tseaver commented Nov 6, 2014

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 7, 2014

tseaver commented Nov 7, 2014

dhermes commented Nov 7, 2014

tseaver commented Nov 7, 2014

dhermes commented Nov 7, 2014

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Nov 7, 2014

dhermes commented Nov 7, 2014