Skip to content

Handling datastore renames key -> keys #1358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Handling datastore renames key -> keys #1358

wants to merge 2 commits into from

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Jan 7, 2016

A repeated Key field occurs on:

  • AllocateIdsResponse
  • AllocateIdsRequest
  • LookupRequest

Can't be merged until v1beta3 is released.

@dhermes dhermes added api: datastore Issues related to the Datastore API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jan 7, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2016
@dhermes dhermes mentioned this pull request Jan 7, 2016
Closed
49 tasks
@dhermes dhermes force-pushed the handle-key-keys-rename-1288 branch from 1bf6fd8 to 9e3474b Compare January 15, 2016 07:20
@dhermes dhermes mentioned this pull request Feb 12, 2016
Merged
@dhermes dhermes closed this Feb 12, 2016
@dhermes dhermes deleted the handle-key-keys-rename-1288 branch February 12, 2016 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhermes @googlebot