-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make synchronous query snippets testable #1836
Make synchronous query snippets testable #1836
Conversation
Rebased after merging #1833 to |
@@ -25,6 +25,7 @@ Authentication / Configuration | |||
>>> from gcloud import bigquery | |||
>>> client = bigquery.Client() | |||
|
|||
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Can we squash this before merging? |
@@ -68,10 +68,10 @@ def delete(self): | |||
|
|||
|
|||
@snippet | |||
def client_list_datasets(client, to_delete): # pylint: disable=unused-argument | |||
def client_list_datasets(client, _): |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
LGTM, I would still squash but whatever you think. |
@daspecster I rebased away the first two net-noop commits. I will merge when Travis passes. |
Uses #1833 as a base.