-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(bigquery): add table create sample using integer range partitioning #9478
doc(bigquery): add table create sample using integer range partitioning #9478
Conversation
This code sample doubles as a system test for integer range partitioning features.
846b60c
to
e1f6921
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please just blacken the changes (the lint check fails).
I noticed that table range partitioning info is not presented anywhere in the GCP control panel, but that's not a client library issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline - even if not necessary, it is a good idea to include the sample in the Sphinx docs, too.
@shollyman Is there anything that you might want to add here before merging? Thanks! Update: Seems like no, merging then. :) |
This code sample doubles as a system test for integer range partitioning features. Follow-up to #9477