Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marshal row data correctly in 'Table.insert_data()' #3426

Merged
merged 4 commits into from
May 18, 2017
Merged

Marshal row data correctly in 'Table.insert_data()' #3426

merged 4 commits into from
May 18, 2017

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented May 16, 2017

Closes #2957.

@tseaver tseaver added api: bigquery Issues related to the BigQuery API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 16, 2017
@tseaver tseaver requested a review from dhermes May 16, 2017 20:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2017
dhermes
dhermes reviewed May 16, 2017
View reviewed changes
bigquery/google/cloud/bigquery/_helpers.py
:returns: A tuple of data converted to native types.
"""
row_data = []
for field, cell in zip(schema, row['f']):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/_helpers.py Outdated
"""Convert JSON row data to rows with appropriate types."""
return [_row_from_json(row, schema) for row in rows]
# Converters used for scalar values marshalled as query parameters.
_SCALAR_VALUE_TO_JSON_PARM = _SCALAR_VALUE_TO_JSON_ROW.copy()

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/table.py Outdated
# Specifies the number of seconds since the epoch.
value = _convert_timestamp(value)
converter = _SCALAR_VALUE_TO_JSON_ROW.get(field.field_type)
if converter is not None:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit 9220dac into googleapis:master May 18, 2017
@tseaver tseaver deleted the 2957-bigquery-table_insert_data-marshalling branch May 18, 2017 19:00
dhermes added a commit that referenced this pull request Jun 2, 2017
@dhermes
Reloading BigQuery table in system test before fetching data.
599357f 
e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in #3426.
@dhermes dhermes mentioned this pull request Jun 2, 2017
Merged
theacodes pushed a commit that referenced this pull request Jun 2, 2017
@dhermes
Reloading BigQuery table in system test before fetching data. (#3468)
38bdb44 
e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in #3426.
@tseaver tseaver mentioned this pull request Jun 26, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@dhermes @landrito
Reloading BigQuery table in system test before fetching data. (google…
ac68480 
…apis#3468)

e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in googleapis#3426.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Reloading BigQuery table in system test before fetching data. (google…
f4e794a 
…apis#3468)

e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in googleapis#3426.
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@dhermes @landrito
Reloading BigQuery table in system test before fetching data. (google…
827a8ad 
…apis#3468)

e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/2065

Error introduced in googleapis#3426.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes left review comments

@lukesneeringer lukesneeringer lukesneeringer left review comments

@dhermes dhermes dhermes approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tseaver @lukesneeringer @theacodes @dhermes @googlebot