Update from master #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Controls whether a user action (e.g is touch event) is required in order to start media playback.
This PR is here to address issues in the quality of video recording for the camera plugin on Android, as well as discrepancies in quality level between Android and iOS. It also allows to control the still picture quality (which was so far only maximum quality). The existing resolution presets have been updated to match between Android and iOS, and new presets have been added. There are no breaking changes but the quality of the presets have been adjusted which will result in different picture/video quality on apps using this plugin. We believe this change is necessary as, for the same resolution preset, Android video quality was very poor and the quality on iOS was too high, generating 4k files that are too heavy to upload.
…hanges in iOS 13 (#1957)
Works around an Android WebView bug that was causing a crash by filtering some DisplayListener invocations. Older Android WebView versions had assumed that when DisplayListener#onDisplayChanged is invoked, the display ID it is provided is of a valid display. However it turns out that when a display is removed Android may call onDisplayChanged with the ID of the removed display, in this case the Android WebView code tries to fetch and use the display with this ID and crashes with an NPE. The issue was fixed in the Android WebView code in https://chromium-review.googlesource.com/517913 which is available starting WebView version 58.0.3029.125 however older webviews in the wild still have this issue. Since Flutter removes virtual displays whenever a platform view is resized the webview crash is more likely to happen than other apps. And users were reporting this issue see: flutter/flutter#30420 This change works around the webview bug by unregistering the WebView's DisplayListener, and instead registering our own DisplayListener which delegates the callbacks to the WebView's listener unless it's a onDisplayChanged for an invalid display.
WebView is incorrectly dropping some input events as unhandled. Previously we were restarting the input connection to try and work around this, but that causes a long tail of bugs in various SDK and WebView versions. Stop the events from bubbling instead since they still appear to be correctly handled despite being marked wrong. Long term we should figure out why this is happening in WebView and figure out a deeper fix for this issue, but this workaround solves the linked bugs in the immediate short term.
If using FragmentActivity, the requestCode used for startActivityForResult needs to be below 65536. See https://stackoverflow.com/questions/25529865/java-lang-illegalargumentexception-can-only-use-lower-16-bits-for-requestcode.
…sions prior to P (#1975) Apply the display listeners workaround on all Android versions prior to P
* [firebase_auth] use long datatype for timestamps (iOS)
Including the webview_flutter plugin currently creates a few warnings rgd. methods not being available on iOS9 and so forth. It may be personal taste, but I find them distracting - and technically the method is not really protected by the @available block so it will be useful to move the code back into it. The plugin also migrates the example project files to the latest Xcode recommendation which removes compilation warnings as well. After this PR, the compiler warnings for the webview_example are gone completely:
…ting disposed (#1886) fixes: flutter/flutter#33299
Allows inspecting the title of the currently loaded page.
…#1981) Reverts #1979 The change broke Fuchsia, as FuchsiaWebViewController implements WebViewPlatformController so it doesn't get the no-op implementation of getTitle. We could change the FuchsiaWebViewController implementation to extend WebViewPlatformController so we can add new methods without requiring roll coordination. I'm reverting temporarily until we resolve the roll issue.
Co-Authored-By: Charles Crete <charles@cretezy.com>
Add support for marker drag events.
* Pause/resume video recording for Android * Specify type * Add pausing and resuming to example app * iOS side of pausing/resuming * More documentation * Version bump * Add video pausing and resuming * get pausing and recording to work for no audio * It works * Formatting * Add test for pausing and resuming * Call success outside try catch block * formatting * Disable audio in test and call result on iOS
* Allow (de-)serialization of CameraPosition * Camera position toMap use fixes * Updated the pubspec and changelog
* [pathprovider] Fix fall through bug
* Fix build failure due to deprecated member use
* Remove Flutterfire plugins (moved to FirebaseExtended) * Remove Flutterfire references from build_all_plugins_app
…1767) * [google_maps_flutter] Adds support for displaying the traffic layer * [google_maps_flutter] Adds traffic layer tests
…plugin third-party dependencies. (#2015) * Use implementation rather than API dependencies for google_sign_in
…1866) This pull request adds Firebase Test Lab Android instrumentation test adapter to the first-party plugins repo. Using the plugin requires calling `InstrumentationAdapterFlutterBinding.ensureInitialized` and using `testWidgets` rather than `test`. Furthermore, a Java test file must be added to the androidTest folder. Examples of this will be provided in a subsequent PR. Ultimately I'd like to refactor the common functionality into engine and see the "flutter create" template include the boilerplate files for running instrumentation tests automatically, but first we need to try them out a bit with plugins and iterate on usability. So I've put the functionality into a plugin. Joint work with @digiter
(documentation-only change)
…FlutterTest (#2023) * Updates the boilerplate test to use `@Rule` instead of `FlutterTest`, bringing it more in line with how native Android tests work.
Added "flags" option to call intent.addFlags(int) in native.
This test was never providing much value since it needed to be run manually and only verified one of the API calls. Manually opening the configured example app took just as much time and verified much more. CI is failing based on it being skipped right now. Remove it completely to unbreak CI.
…2028) * Update documentation about how to use androidx. * Increase patch version. * Fix change log.
…d registrations. (#2014) This PR delays the get of a reference of a Activity instance and raises an error in case of a invalid access to the method that uses it.
…4. (#2029) This PR fixes a crash when pause/resume methods are called in APIs lower than 24 on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.