Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps] Set correct polyline width when building polylines. #1935

Merged
merged 4 commits into from
Aug 7, 2019
Merged

[google_maps] Set correct polyline width when building polylines. #1935

merged 4 commits into from
Aug 7, 2019

Conversation

KlausJokisuo
Copy link
Contributor

@KlausJokisuo KlausJokisuo commented Jul 31, 2019 •
edited
Loading

Description

Currently when you start GoogleMaps widget first time, the widget won't take device display metrics into account and only when you reload state of the widget the metrics are applied to polyline width. As far as I know, this issue is only on Android platform.

Related Issues

flutter/flutter#36754

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@SirJohn2024
Copy link

Well done... :-)

@iskakaushik
Copy link
Contributor

Could you please update the pubspec.yml and CHANGELOG.md please. Increase the hotfix number after + sign. Thanks for the contribution.

iskakaushik
iskakaushik approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KlausJokisuo
Copy link
Contributor Author

@iskaushik.
Updated changelog and pubspec. Is there something else I need to do before this can be merged?

@iskakaushik iskakaushik merged commit 8c8bec0 into flutter:master Aug 7, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
@KlausJokisuo
[google_maps] Set correct polyline width when building polylines. (fl…
6d4f4af 
…utter#1935)

* Fix polyline width when created by adding density option to PolyLineBuilder class

* Version bump

* Adjust changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iskakaushik iskakaushik iskakaushik approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KlausJokisuo @SirJohn2024 @iskakaushik @googlebot