Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Remove skipped driver test #2027

Merged
merged 2 commits into from
Aug 28, 2019
Merged

[in_app_purchase] Remove skipped driver test #2027

merged 2 commits into from
Aug 28, 2019

Conversation

mklim
Copy link
Contributor

@mklim mklim commented Aug 28, 2019

Description

This test was never providing much value since it needed to be run
manually and only verified one of the API calls. Manually opening the
configured example app took just as much time and verified much more. CI
is failing based on it being skipped right now. Remove it completely to
unbreak CI.

Related Issues

flutter/flutter#29462
https://cirrus-ci.com/task/5776347504312320

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

/cc @BugsBunnyBR

This test was never providing much value since it needed to be run
manually and only verified one of the API calls. Manually opening the
configured example app took just as much time and verified much more. CI
is failing based on it being skipped right now. Remove it completely to
unbreak CI.
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to update version and CHANGELOG before commit

@mklim
Copy link
Contributor Author

mklim commented Aug 28, 2019

LGTM! Remember to update version and CHANGELOG before commit

I wasn't planning on publishing the changes here on their own since they're just removing a normally unused test within the plugin itself. Do you think it's worth pushing?

@collinjackson
Copy link
Contributor

Personally I'm in favor of releasing whenever anything changes, patch changes don't really create work for anyone and it avoids a situation where someone could be confused by differences between pub and GitHub.

@mklim
Copy link
Contributor Author

mklim commented Aug 28, 2019

Makes sense, updated.

@mklim mklim merged commit 406ec35 into flutter:master Aug 28, 2019
@mklim mklim deleted the remove_iap_driver_test branch August 28, 2019 22:45
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
This test was never providing much value since it needed to be run
manually and only verified one of the API calls. Manually opening the
configured example app took just as much time and verified much more. CI
is failing based on it being skipped right now. Remove it completely to
unbreak CI.
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
This test was never providing much value since it needed to be run
manually and only verified one of the API calls. Manually opening the
configured example app took just as much time and verified much more. CI
is failing based on it being skipped right now. Remove it completely to
unbreak CI.
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* Add macOS availability to the README.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants