Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[android_alarm_manager] Added ability to get id in the callback #1985

Merged
merged 7 commits into from
Aug 19, 2019
Merged

[android_alarm_manager] Added ability to get id in the callback #1985

merged 7 commits into from
Aug 19, 2019

Conversation

Afsar-Pasha
Copy link
Contributor

@Afsar-Pasha Afsar-Pasha commented Aug 17, 2019

Description

Added ability to get id in the callback.

Related Issues

#31658 Getting alarm ID in callback

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Afsar-Pasha Afsar-Pasha requested a review from bkonyi as a code owner August 17, 2019 17:33
@Afsar-Pasha Afsar-Pasha changed the title [android_alarm_manager] Added ability to get id in the callback [android_alarm_manager] Added ability to get id in the callback Aug 17, 2019
Co-Authored-By: Charles Crete <charles@cretezy.com>
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me.

@bkonyi bkonyi merged commit 4a7ddd2 into flutter:master Aug 19, 2019
@ahmednet0001
Copy link

How I can use it to get ID of alarm in callback ?

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants