This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Revert "[webview_flutter] Add a getTitle method to WebViewController" #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
force-pushed
the
revert-1979-getTitle
branch
from
068bb3d to
2cd3657
Compare
|
Landing without waiting for CI as this is a clean revert. |
amirh
added a commit
to amirh/plugins
that referenced
this pull request
Sep 10, 2019
…flutter#1981)" This reverts commit e4feab6.
amirh
added a commit
that referenced
this pull request
Sep 10, 2019
noelmansour
pushed a commit
to snowble/plugins
that referenced
this pull request
Nov 13, 2019
…flutter#1981)" (flutter#2056) This reverts commit e4feab6.
mormih
pushed a commit
to mormih/plugins
that referenced
this pull request
Nov 17, 2019
…flutter#1981)" (flutter#2056) This reverts commit e4feab6.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…flutter#1981) Reverts flutter#1979 The change broke Fuchsia, as FuchsiaWebViewController implements WebViewPlatformController so it doesn't get the no-op implementation of getTitle. We could change the FuchsiaWebViewController implementation to extend WebViewPlatformController so we can add new methods without requiring roll coordination. I'm reverting temporarily until we resolve the roll issue.
sungmin-park
pushed a commit
to sungmin-park/flutter-plugins
that referenced
this pull request
Dec 17, 2019
…flutter#1981)" (flutter#2056) This reverts commit e4feab6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1979
The change broke Fuchsia, as FuchsiaWebViewController implements WebViewPlatformController so it doesn't get the no-op implementation of getTitle. We could change the FuchsiaWebViewController implementation to extend WebViewPlatformController so we can add new methods without requiring roll coordination.
I'm reverting temporarily until we resolve the roll issue.