Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_admob] Banner Ad Horizontal Positioning #1925

Merged
merged 3 commits into from
Aug 16, 2019
Merged

[firebase_admob] Banner Ad Horizontal Positioning #1925

merged 3 commits into from
Aug 16, 2019

Conversation

malsabbagh
Copy link
Contributor

Adding the ability to horizontally adjust the ads banner location by specifying an offset from the centre.

Description

  • This PR allows the user of firebase_admob to specify an offset in pixels from the horizontal centre of the banner using
  • horizontalCenterOffset

The current behaviour allows the user only to specify an anchor top or bottom with an offset from the anchor. But it doesn't allow an offset from the horizontal centre. This PR will add that ability.

The motivation behind the change is to support split screen layout for tablets where ads banner could reside on one side of the screen.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Adding the ability to horizontally adjust the ads location by specifying an offset from the centre.
@malsabbagh
Copy link
Contributor Author

Hey @amirh & @bparrishMines,

Do you think this would be merged or there are plans that would affect this behaviour to prevent it from being merged in the future? It will be nice to have this as part of the next firebase_admob update.

Thanks,

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the contribution!

@bparrishMines bparrishMines merged commit c8f0c27 into flutter:master Aug 16, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants