-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[connectivity] update the connectivity readme to include info about changes in iOS 13 #1957
Conversation
@cyanglaz Do I also need to increment the package version and add to the changelog, since it's just a readme change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this! It is a really nice starting point.
I left some comments, and we also need to update the pubspec and changelog to a new version so we can publish this readme to pub
@danwulff Also, I think the fix you mentioned in flutter/flutter#37804 with the location request is pretty straightforward. If you want to include the fix in a same PR I'm happy to review it too. |
@cyanglaz I would love to make the code changes as well, but I don't have the ability to test with iOS 13 currently. Will make changes per your suggestions by end of day. |
@danwulff That's great! Thanks! There is no rush, please take your time :) |
@cyanglaz Let me know if you see any other changes that need to happen. |
@danwulff Can we include the fixes in this same PR? |
@cyanglaz I can't sorry. I don't have the capability of using Xcode 11 (iOS 13 SDK). If you or another googler want to add on to this PR feel free. |
Description
Update the Readme for the Connectivity plugin to include information about changes in iOS 13.
Specifically the tightening of security around SSID and BSSID information.
Apple's email announcing the change:

Apple's documentation about CNCopyCurrentNetworkInfo
Related Issues
Resolves: #35322
A followup issue has been created for "fixing" the iOS 13 functionality at #37804
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?