Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Added formatHint to to override video format on Android #2003

Merged
merged 7 commits into from
Aug 23, 2019
Merged

[video_player] Added formatHint to to override video format on Android #2003

merged 7 commits into from
Aug 23, 2019

Conversation

jtmcdole
Copy link
Contributor

@jtmcdole jtmcdole commented Aug 22, 2019

Description

Passes down the suggested video format for use when URLs do not include a file path.

flutter/flutter#39076

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, left some comments.

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, left some nit comments.
If you are able to add a test for the formatHint passing to the method channel correct in initialize, that'd be great!

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge on green

@cyanglaz cyanglaz changed the title Pass down the format #39076 [video_player] Added formatHint to to override video format on Android #39076 Aug 23, 2019
@cyanglaz cyanglaz changed the title [video_player] Added formatHint to to override video format on Android #39076 [video_player] Added formatHint to to override video format on Android Aug 23, 2019
@cyanglaz cyanglaz merged commit 7f37ed5 into flutter:master Aug 23, 2019
@jtmcdole
Copy link
Contributor Author

Thank you!

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants