Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Depend on AndroidX Core instead of Legacy Support v4 #1934

Merged
merged 2 commits into from
Aug 9, 2019
Merged

[image_picker] Depend on AndroidX Core instead of Legacy Support v4 #1934

merged 2 commits into from
Aug 9, 2019

Conversation

ChristianKatzmann
Copy link
Contributor

Description

It's not recommended to depend on the legacy-support-v4 artifact any longer as we should depend on the relevant sub-artifacts instead to reduce the transitive dependencies.

The image_picker package only uses classes from the androidx.core package, so we can safely replace the androidx.legacy:legacy-support-v4 dependency with androidx.core:core.

Related Issues

This simple change is part of the PR #1878.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mklim mklim self-assigned this Aug 8, 2019
@mklim mklim self-requested a review August 8, 2019 18:12
Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

Co-Authored-By: Michael Klimushyn <mklim@google.com>
@cyanglaz cyanglaz merged commit b48dd36 into flutter:master Aug 9, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants