[flutter_google_maps] Upgrade google-services-maps v17.0.0 - AndroidX compatible

[JamesMcIntosh]

Description

This library says that it is AndroidX compatible but the Android google-services-maps dependencies have not been upgraded to an AndroidX compatible version

In the checklist below, I am unsure if you would class this as a breaking change and if the version bump is correct.

Related Issues

For me it was causing an incompatibility with flutter image_picker
flutter/flutter#27194

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• [N/A] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[JamesMcIntosh]

Timeout issues with the builds above, don't think it's caused by my commit.

[kjeremy]

Any news on this?

[JamesMcIntosh]

@iskakaushik could you please able to give feedback to whether this PR is being reviewed/considered? Many thanks!

[iskakaushik]

Hi @JamesMcIntosh i'm worried about any breaking changes that happened between the two versions of the API. Are you aware of any?

[JamesMcIntosh]

@iskakaushik I am not aware of any API changes, it looks as though only the underlying Google Maps API other than Android Support Libraries are changed to AndroidX.

If the Maps API had changed in regards to any functionality which is used in the Flutter Plugin then there would have been a compilation issue...

I have been running a fork and creating maps using Polygons, Markers, Location and manipulating the camera position etc. with no issue.

Even if you're worried about the Android Support to AndroidX change it is already causing a problem with it not being AndroidX when the plugin says that it should be and the other plugins in the repository having already migrated to AndroidX is causing an incompatibility. If you don't bump it up you're stuck at this release and can't get any of the bugfixes etc. in the Android Google Maps releases. If the Android API changes it shouldn't matter, Flutter Google Maps is in Developer Preview still and you'll need to fix the Android integration anyway as you can't stay on this version forever.

[JamesMcIntosh]

I've found the release notes, they're not overly helpful.
https://developers.google.com/maps/documentation/android-sdk/releases
https://developers.google.com/android/guides/releases

[kjeremy]

It's just a move to AndroidX. I think most of the other plugins have already been migrated.

…

On Mon, Aug 12, 2019, 11:55 PM James McIntosh ***@***.***> wrote: I've found the release notes, they're not overly helpful. https://developers.google.com/maps/documentation/android-sdk/releases https://developers.google.com/android/guides/releases — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1941?email_source=notifications&email_token=ABBACRAFV73KXT5QMHVZMN3QEIWDTA5CNFSM4II4LIHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4EO4NA#issuecomment-520678964>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABBACRBGFUIWM3ALOXORJ6TQEIWDTANCNFSM4II4LIHA> .

[iskakaushik]

I looked through the changes between the versions. Seems like a safe update. LGTM.