Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[instrumentation_adapter] Update documentation about using androidx #2028

Merged
merged 3 commits into from
Aug 29, 2019
Merged

[instrumentation_adapter] Update documentation about using androidx #2028

merged 3 commits into from
Aug 29, 2019

Conversation

digiter
Copy link
Contributor

@digiter digiter commented Aug 28, 2019

Description

  • Update instructions about using androidx.
  • Use the latest stable release of androidx library.
  • Also formatted the README.md.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@collinjackson collinjackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine (although I'm a bit confused how it was working for me before). Should we update the Flutter template app's build.gradle to make this the default so developers don't need to update their apps?

@digiter
Copy link
Contributor Author

digiter commented Aug 28, 2019

I'd like to polish this for a few more rounds before touching Flutter template app.

@digiter digiter merged commit b47754c into flutter:master Aug 29, 2019
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
…lutter#2028)

* Update documentation about how to use androidx.
* Increase patch version.
* Fix change log.
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
…lutter#2028)

* Update documentation about how to use androidx.
* Increase patch version.
* Fix change log.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants