Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[android_alarm_manager] Added oneShotAt method to schedule a alarm at a given time #1947

Merged
merged 11 commits into from
Aug 12, 2019
Merged

Conversation

Afsar-Pasha
Copy link
Contributor

@Afsar-Pasha Afsar-Pasha commented Aug 5, 2019

Description

Added a static oneShotAt method to AndroidAlarmManager to run callback at a given DateTime time.

Related Issues

None

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Everything looks good for the most part, just a couple of small adjustments.

Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! Looks good to me overall, just one minor style change for approval.

@bkonyi
Copy link
Contributor

bkonyi commented Aug 12, 2019

Sorry, I missed the formatting error on the last review. If you could just run dartfmt on android_alarm_manager.dart and resubmit, I'll go ahead and merge this. Thanks!

@bkonyi
Copy link
Contributor

bkonyi commented Aug 12, 2019

Fixes flutter/flutter#27115

@bkonyi bkonyi merged commit 993f895 into flutter:master Aug 12, 2019
@bkonyi
Copy link
Contributor

bkonyi commented Aug 12, 2019

Published on pub.dev as 0.4.3. Fixes flutter/flutter#37534

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants