Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[webview_flutter] Fix double tap on resize issue #1965

Merged
merged 1 commit into from
Aug 10, 2019
Merged

[webview_flutter] Fix double tap on resize issue #1965

merged 1 commit into from
Aug 10, 2019

Conversation

mklim
Copy link
Contributor

@mklim mklim commented Aug 9, 2019

Description

WebView is incorrectly dropping some input events as unhandled.
Previously we were restarting the input connection to try and work
around this, but that causes a long tail of bugs in various SDK and
WebView versions. Stop the events from bubbling instead since they still
appear to be correctly handled despite being marked wrong.

Long term we should figure out why this is happening in WebView and
figure out a deeper fix for this issue, but this workaround solves the
linked bugs in the immediate short term.

Related Issues

Fixes flutter/flutter#36978.
Fixes flutter/flutter#35867.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mklim mklim requested a review from amirh August 9, 2019 22:11
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's file an issue tracking the auto suggestions issue

WebView is incorrectly dropping some input events as unhandled.
Previously we were restarting the input connection to try and work
around this, but that causes a long tail of bugs in various SDK and
WebView versions. Stop the events from bubbling instead since they still
appear to be correctly handled despite being marked wrong.

Long term we should figure out why this is happening in WebView and
figure out a deeper fix for this issue, but this workaround solves the
linked bugs in the immediate short term.
@mklim
Copy link
Contributor Author

mklim commented Aug 9, 2019

Filed flutter/flutter#37989.

@mklim mklim merged commit 560694c into flutter:master Aug 10, 2019
@mklim mklim deleted the webview_input_drop branch August 10, 2019 00:31
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
WebView is incorrectly dropping some input events as unhandled.
Previously we were restarting the input connection to try and work
around this, but that causes a long tail of bugs in various SDK and
WebView versions. Stop the events from bubbling instead since they still
appear to be correctly handled despite being marked wrong.

Long term we should figure out why this is happening in WebView and
figure out a deeper fix for this issue, but this workaround solves the
linked bugs in the immediate short term.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants