Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

fix android crash when pausing or resuming video on APIs lower than 24. #2029

Merged
merged 1 commit into from
Aug 29, 2019
Merged

fix android crash when pausing or resuming video on APIs lower than 24. #2029

merged 1 commit into from
Aug 29, 2019

Conversation

juliocbcotta
Copy link
Contributor

Description

This PR fixes a crash when pause/resume methods are called in APIs lower than 24 on Android.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM. It's unfortunate but I don't think we could add a meaningful test for this as-is since it depends on a specific Android version and we don't have working JUnit tests in the plugins.

I filed flutter/flutter#39499 to try and avoid errors like this in the future. @bparrishMines this is something to keep in mind with the refactor, I think ideally we'd probably want better behavior here instead of just failing to pause and resume.

@mklim mklim merged commit cd40169 into flutter:master Aug 29, 2019
@juliocbcotta
Copy link
Contributor Author

Thanks for the fix! LGTM. It's unfortunate but I don't think we could add a meaningful test for this as-is since it depends on a specific Android version and we don't have working JUnit tests in the plugins.

I filed flutter/flutter#39499 to try and avoid errors like this in the future. @bparrishMines this is something to keep in mind with the refactor, I think ideally we'd probably want better behavior here instead of just failing to pause and resume.

I think we can add a test, but it will require to encapsulate the call to Build.VERSION.SDK_INT >= Build.VERSION_CODES.N in a wrapper class and the test needs to run in Robolectric or in a device.

mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
…4. (flutter#2029)

This PR fixes a crash when pause/resume methods are called in APIs lower than 24 on Android.
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
…4. (flutter#2029)

This PR fixes a crash when pause/resume methods are called in APIs lower than 24 on Android.
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
…4. (flutter#2029)

This PR fixes a crash when pause/resume methods are called in APIs lower than 24 on Android.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants