Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] use long datatype for timestamps (iOS) #1973

Merged
merged 2 commits into from
Aug 13, 2019

Conversation

ened
Copy link
Contributor

@ened ened commented Aug 13, 2019

Description

Reduces a few compiler warnings in the firebase_auth plugin that were caused by using [NSNumber numberWithInt] when numberWithLong would have worked as well.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@ened
Copy link
Contributor Author

ened commented Aug 13, 2019

@googlebot I fixed it.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@kroikie
Copy link
Contributor

kroikie commented Aug 13, 2019

@ened this looks good, thanks. Could you bump the version and add a note in the CHANGELOG before I merge?

@kroikie kroikie merged commit e2f0f2d into flutter:master Aug 13, 2019
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
* [firebase_auth] use long datatype for timestamps (iOS)
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
* [firebase_auth] use long datatype for timestamps (iOS)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants