2025-05-21, Version 24.1.0 (Current) #58406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
PR-URL: #57099 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #57916 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #57916 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #57916 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #58083 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
PR-URL: #58003 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
PR-URL: #58003 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
By the time the response event is emitted on the client's side, the file may have already been fully piped and the stream pipe may have been destroyed, so the test should not look for the stream pipe in the snapshot. PR-URL: #58148 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #57924 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #58141 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
I added this class in 823d86c in 2018 when we did not yet use `std::optional`. The last uses were removed in 5b9bf39, so remove it. Refs: #24234 Refs: #55368 PR-URL: #58168 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame. PR-URL: #58149 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Co-Authored-By: richardlau - Richard Lau <rlau@redhat.com> PR-URL: #58090 Refs: #57934 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #58174 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE). PR-URL: #58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Now that `CipherBase.init` has been removed, instances of the class are always initialized by a call to `initiv` immediately after the constructor has returned. Instead of calling into C++ twice from `createCipherBase`, pass all required arguments to the constructor and fully initialize the instance before the constructor returns. PR-URL: #58166 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This has shown up as RangeError: Array buffer allocation failed and it should be totally fine to skip this test in case the memory is low. PR-URL: #58142 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #58184 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Signed-off-by: Michael Dawson <midawson@redhat.com> PR-URL: #58122 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This change refactors `StringBytes::WriteUCS2()` in multiple ways. The `flags` argument being passed to `WriteUCS2()` is not useful: the only really relevant flag is `NO_NULL_TERMINATION` since V8 ignores `REPLACE_INVALID_UTF8`, `HINT_MANY_WRITES_EXPECTED`, and `PRESERVE_ONE_BYTE_NULL` for UTF-16 strings. However, `WriteUCS2()` might not null-terminate the result correctly regardless of whether `NO_NULL_TERMINATION` is set because it makes multiple calls to `String::Write()` internally. For these reasons, this patch removes the `flags` argument entirely and always assumes `NO_NULL_TERMINATION`. Next, this patch replaces the calls to the deprecated function `String::Write()` with calls to the new function `String::WriteV2()`, which always succeeds and always writes a predictable number of characters, removing the need to deal with a return value here. Lastly, this patch simplifies the implementation of `WriteUCS2()` and computes the exact number of characters `nchars` from the beginning, removing the need to later check again if the number of characters is zero. PR-URL: #58163 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Node calls tcsetattr on exit to reset the tty to its state on program start. Good idea in general but tcsetattr can fail for a number of reasons and since there really isn't anything we can do about it at that point, simply ignore the error instead of aborting with an inscrutable error message. Most of the time it'll be fine because the most common failure is when the user has already logged off and there isn't anything to restore in the first place. Fixes: #51519 PR-URL: #58200 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: #58143 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Since `String::Write()` is deprecated, use `String::WriteV2()` instead. PR-URL: #58164 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #58285 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #58291 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #58292 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
The current documentation lists the `callback` argument of `crypto.generatePrime` as optional (it's surrounded by square brackets), but this is incorrect - calling the function without a callback will result in an `ERR_INVALID_ARG_TYPE` error: For the record, the correct way to generate a prime synchronously, without a callback, is to use the `generatePrimeSync` API. This patch fixes the documentation and marks the callback argument as mandatory. The `options` (second) argument, is indeed optional, and is marked as such. Fixes: #58298 PR-URL: #58299 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
PR-URL: #58294 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #58339 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
PR-URL: #58254 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #58356 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Fixes: #57410 PR-URL: #58355 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 fs: * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 test_runner: * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202 PR-URL: #58406
github-actions
bot
added
release
|
Review requested:
|
aduh95
approved these changes
May 20, 2025
github-actions
bot
removed
the
request-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v24.x #58406 +/- ##
==========================================
+ Coverage 90.13% 90.24% +0.10%
==========================================
Files 630 632 +2
Lines 186650 187024 +374
Branches 36638 36711 +73
==========================================
+ Hits 168245 168775 +530
+ Misses 11199 11043 -156
Partials 7206 7206
🚀 New features to boost your workflow:
|
aduh95
pushed a commit
that referenced
this pull request
May 21, 2025
Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 fs: * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 test_runner: * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202 PR-URL: #58406
aduh95
added a commit
to aduh95/nodejs.org
that referenced
this pull request
May 21, 2025
5 tasks
github-merge-queue bot
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable Changes
9d35b4ce95] - doc: add JonasBa to collaborators (Jonas Badalic) #58355b7d1bfa7b4] - doc: add puskin to collaborators (Giovanni Bucci) #58308fcead7c28e] - (SEMVER-MINOR) fs: add toDirsupport for explicit resource management (Antoine du Hamel) #58206f7041b9369] - Revert "test_runner: change ts default glob" (Théo LUDWIG) #58202Commits
b33e8d2a71] - async_hooks: ensure AsyncLocalStore instances work isolated (Gerhard Stöbich) #58149a1b078b18c] - buffer: give names toBuffer.prototype.*Write()functions (Livia Medeiros) #582584c967b73c3] - buffer: use constexpr where possible (Yagiz Nizipli) #58141327095a928] - build: fix uvwasi pkgname (Antoine du Hamel) #582702e54653d3d] - build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch (RafaelGSS) #580907e4453fe93] - build: escape > metachar in vcbuild (Gerhard Stöbich) #581577dabf079b1] - child_process: give names to promisifiedexec()andexecFile()(LiviaMedeiros) #57916a896eff1f2] - crypto: handle missing OPENSSL_TLS_SECURITY_LEVEL (Shelley Vohr) #581036403aa458f] - crypto: merge CipherBase.initiv into constructor (Tobias Nießen) #5816630897d915c] - deps: V8: backport 1d3362c55396 (Shu-yu Guo) #5823063f5d69d2b] - deps: V8: cherry-pick 4f38995c8295 (Shu-yu Guo) #582305a5f6bb1d4] - deps: V8: cherry-pick 044b9b6f589d (Rezvan Mahdavi Hezaveh) #58230db57f0a4c0] - deps: patch V8 to 13.6.233.10 (Michaël Zasso) #58230f54a7a44ab] - Revert "deps: patch V8 to support compilation with MSVC" (Michaël Zasso) #58187e3193eeca4] - Revert "deps: always define V8_EXPORT_PRIVATE as no-op" (Michaël Zasso) #58187e75ecf8ad1] - Revert "deps: disable V8 concurrent sparkplug compilation" (Michaël Zasso) #58187a0ca15558d] - deps: update llhttp to 9.3.0 (Fedor Indutny) #5814490d4c11992] - deps: update amaro to 0.5.3 (Node.js GitHub Bot) #581749d35b4ce95] - doc: add JonasBa to collaborators (Jonas Badalic) #583552676ca0cf5] - doc: add latest security release steward (Rafael Gonzaga) #58339c35cc1bdd9] - doc: document default test-reporter change (Nico Jansen) #583022bb433d4a5] - doc: fix CryptoKey.algorithm type and other interfaces in webcrypto.md (Filip Skokan) #58294f04f09d783] - doc: mark the callback argument of crypto.generatePrime as mandatory (Allon Murienik) #582993b9b010844] - doc: remove comma delimiter mention on permissions doc (Rafael Gonzaga) #58297f0cf1a028d] - doc: make Stability labels not sticky in Stability index (Livia Medeiros) #58291a1b937bdee] - doc: update commit-queue documentation (Dario Piotrowicz) #58275b7d1bfa7b4] - doc: add puskin to collaborators (Giovanni Bucci) #58308fc30cdd8d2] - doc: update stability status for diagnostics_channel to experimental (Idan Goshen) #58261290a5ab8ca] - doc: clarify napi_get_value_string_* for bufsize 0 (Tobias Nießen) #58158c26863a683] - doc: fix typo of filehttp.md,outgoingMessage.setTimeoutsection (yusheng chen) #5818862dbd36dcb] - doc: update return types for eventNames method in EventEmitter (Yukihiro Hasegawa) #58083130c135f38] - fs: add support forURLforfs.glob'scwdoption (Antoine du Hamel) #58182fcead7c28e] - (SEMVER-MINOR) fs: add toDirsupport for explicit resource management (Antoine du Hamel) #58206655326ba9f] - fs: glob is stable, so should not emit experimental warnings (Théo LUDWIG) #582366ebcce7625] - fs: ensuredir.read()does not throw synchronously (Antoine du Hamel) #582287715722323] - http: remove unused functions and add todos (Yagiz Nizipli) #5814374a807e31f] - http,https: give names to anonymous or misnamed functions (Livia Medeiros) #5818024a9aefb08] - http2: add diagnostics channel 'http2.client.stream.start' (Darshan Sen) #582922cb86a3cd6] - http2: add diagnostics channel 'http2.client.stream.created' (Darshan Sen) #582468f1aee90d9] - http2: give name to promisifiedconnect()(LiviaMedeiros) #57916b66f1b0be6] - inspector: support for worker inspection in chrome devtools (Shima Ryuhei) #56759868e72e367] - lib: fix sourcemaps with ts module mocking (Marco Ippolito) #58193570cb6f6b6] - meta: ignore mailmap changes in linux ci (Jonas Badalic) #58356b94f63b865] - module: handle instantiated async module jobs in require(esm) (Joyee Cheung) #58067714b706f2e] - repl: add proper vertical cursor movements (Giovanni Bucci) #58003629a954477] - repl: add possibility to edit multiline commands while adding them (Giovanni Bucci) #5800317746129f3] - sqlite: setnameandlengthonsqlite.backup()(Livia Medeiros) #58251908782b1c0] - sqlite: add build option to build without sqlite (Michael Dawson) #58122a92a4074e4] - src: remove unusedinternalVerifyIntegrityinternal binding (Dario Piotrowicz) #58285e0355b71ba] - src: add a variant of ToV8Value() for primitive arrays (Aditi) #57576cb24fc71c4] - src: remove unusedcheckMessagePortinternal binding (Dario Piotrowicz) #582674db5d0bc49] - src: remove unusedshouldRetryAsESMinternal binding (Dario Piotrowicz) #582653b8d4e32ca] - src: add a couple fast apis in node_os (James M Snell) #58210a135c0aea3] - src: remove unneeded explicit V8 flags (Michaël Zasso) #58230abeb5c4cdc] - src: fix module buffer allocation (X-BW) #577389ca4b46eb3] - src: use String::WriteV2() in TwoByteValue (Tobias Nießen) #58164bb28e2bfd7] - src: remove overzealous tcsetattr error check (Ben Noordhuis) #58200329e008e73] - src: refactor WriteUCS2 and remove flags argument (Tobias Nießen) #58163c815f29d61] - src: remove NonCopyableMaybe (Tobias Nießen) #58168685d137dec] - test: reduce iteration count in test-child-process-stdout-flush-exit (Antoine du Hamel) #5827340dc092e25] - test: remove unnecessaryconsole.logfrom test-repl-null-thrown (Dario Piotrowicz) #58281a3af644dda] - test: allowtmpDir.pathto be modified (Aviv Keller) #5817397f80374a6] - test: addFloat16Arraytocommon.getArrayBufferViews()(Livia Medeiros) #5823365683735ab] - test: fix executable flags (Livia Medeiros) #58250ebb82aa1c3] - test: deflake test-http2-client-socket-destroy (Luigi Pinca) #58212eb4f130b17] - test: remove Float16Array flag (Livia Medeiros) #5818409a85fdeb1] - test: skip test-buffer-tostring-rangeerror when low on memory (Ruben Bridgewater) #5814265446632b1] - test: reduce flakiness in test-heapdump-http2 (Joyee Cheung) #58148f7041b9369] - Revert "test_runner: change ts default glob" (Théo LUDWIG) #58202287454298d] - test_runner: unify --require and --import behavior when isolation none (Pietro Marchini) #579246301b003f7] - tools: ignoredeps/andbenchmark/for CodeQL (Rafael Gonzaga) #582542d5de7e309] - tools: add read permission to workflows that read contents (Antoine du Hamel) #58255b8d4715527] - tools: support environment variables via comments (Pietro Marchini) #58186d8e88f2c17] - typings: add missing typings forTypedArray(Jason Zhang) #582484c6f73c5d5] - url: improve performance of the format function (Giovanni Bucci) #5709994c720c4ee] - util: add internalassignFunctionName()function (LiviaMedeiros) #579163ed159afd1] - watch: fix watch args not being properly filtered (Dario Piotrowicz) #58279