Skip to content

test: reduce iteration count in test-child-process-stdout-flush-exit #58273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 11, 2025

This commit was added by @addaleax to fix the CI in #58124, opening it as a separate PR as the automation keeps removing it from the other PR. This should be landed manually so the commit authorship is credited to Anna and not myself.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 11, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (a822a1c) to head (3a5b89e).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58273      +/-   ##
==========================================
- Coverage   90.17%   90.16%   -0.01%     
==========================================
  Files         631      631              
  Lines      186652   186652              
  Branches    36660    36670      +10     
==========================================
- Hits       168312   168299      -13     
- Misses      11121    11127       +6     
- Partials     7219     7226       +7     

see 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 11, 2025
@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label May 11, 2025
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit f94d676 into nodejs:main May 13, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f94d676

@aduh95 aduh95 deleted the fix-test-for-libuv-update branch May 14, 2025 06:30
targos pushed a commit that referenced this pull request May 16, 2025
PR-URL: #58273
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants