-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
test: reduce iteration count in test-child-process-stdout-flush-exit #58273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:fix-test-for-libuv-update
May 13, 2025
Merged
test: reduce iteration count in test-child-process-stdout-flush-exit #58273
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:fix-test-for-libuv-update
May 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58273 +/- ##
==========================================
- Coverage 90.17% 90.16% -0.01%
==========================================
Files 631 631
Lines 186652 186652
Branches 36660 36670 +10
==========================================
- Hits 168312 168299 -13
- Misses 11121 11127 +6
- Partials 7219 7226 +7 🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 11, 2025
addaleax
approved these changes
May 11, 2025
jasnell
approved these changes
May 12, 2025
Landed in f94d676 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58273 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was added by @addaleax to fix the CI in #58124, opening it as a separate PR as the automation keeps removing it from the other PR. This should be landed manually so the commit authorship is credited to Anna and not myself.