Skip to content

fs: glob is stable, so should not emit experimental warnings #58236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theoludwig
Copy link
Contributor

In #57513 fs.glob was marked as stable, but that was only in the documentation, so if it's considered stable, it should not emit experimental warnings.

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem. labels May 8, 2025
@theoludwig
Copy link
Contributor Author

cc @jasnell

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. lts-watch-v22.x PRs that may need to be released in v22.x labels May 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (e38ce27) to head (2a9f442).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58236      +/-   ##
==========================================
- Coverage   90.14%   90.12%   -0.02%     
==========================================
  Files         629      629              
  Lines      186634   186626       -8     
  Branches    36616    36624       +8     
==========================================
- Hits       168236   168203      -33     
- Misses      11204    11217      +13     
- Partials     7194     7206      +12     
Files with missing lines Coverage Δ
lib/fs.js 98.26% <ø> (-0.01%) ⬇️
lib/internal/fs/promises.js 98.23% <ø> (-0.01%) ⬇️
lib/path.js 96.02% <ø> (-0.07%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. lts-watch-v22.x PRs that may need to be released in v22.x needs-ci PRs that need a full CI run. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants