doc: add puskin to collaborators #58308
Conversation
nodejs-github-bot
added
doc
puskin
added
notable-change
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
|
Fast-track has been requested by @puskin. Please 👍 to approve. |
| @@ -204,6 +204,7 @@ George Adams <gadams@microsoft.com> <george.adams@uk.ibm.com> | |||
| Gerhard Stöbich <deb2001-github@yahoo.de> | |||
| Gibson Fahnestock <gibfahn@gmail.com> <gib@uk.ibm.com> | |||
| Gil Pedersen <git@gpost.dk> <github@gpost.dk> | |||
| Giovanni Bucci <github@puskin.it> | |||
There was a problem hiding this comment.
Out of curiosity, why this addition?
There was a problem hiding this comment.
Otherwise the find-inactive tool was flagging it. I think there is a mismatch between emails
There was a problem hiding this comment.
Ah right, it must the name that mismatches (commit author is Giovanni <github@puskin.it>, while the tool is looking for Giovanni Bucci <github@puskin.it>)
There was a problem hiding this comment.
it is part of this doc: https://github.com/nodejs/node/blob/main/onboarding.md#exercise-make-a-pull-request-adding-yourself-to-the-readme .
It says:
Run tools/find-inactive-collaborators.mjs. If that command outputs your name, amend the commit to include an addition to the [mailmap](https://github.com/nodejs/node/blob/main/.mailmap) file. See [gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the format of the mailmap file.
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e8c06a5 |
Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 fs: * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 test_runner: * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202 PR-URL: #58406
Notable changes: doc: * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 fs: * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 test_runner: * Revert "test_runner: change ts default glob (Théo LUDWIG) #58202 PR-URL: #58406
Notable changes: assert: * (SEMVER-MINOR) mark partialDeepStrictEqual() as stable (Ruben Bridgewater) #57370 doc: * deprecate passing an empty string to `options.shell` (Antoine du Hamel) #58564 * deprecate HTTP/2 priority signaling (Matteo Collina) #58313 * add Filip Skokan to TSC (Rafael Gonzaga) #58499 * add JonasBa to collaborators (Jonas Badalic) #58355 * add puskin to collaborators (Giovanni Bucci) #58308 * mark multiple APIs stable (James M Snell) #57513 fs: * (SEMVER-MINOR) add autoClose option to FileHandle readableWebStream (James M Snell) #58548 * (SEMVER-MINOR) add to `Dir` support for explicit resource management (Antoine du Hamel) #58206 http: * deprecate instantiating classes without new (Yagiz Nizipli) #58518 http2: * (SEMVER-MINOR) add diagnostics channel 'http2.server.stream.finish' (Darshan Sen) #58560 lib: * (SEMVER-MINOR) graduate error codes that have been around for years (James M Snell) #58541 src,permission: * implicit allow-fs-read to app entrypoint (Rafael Gonzaga) #58579 util: * (SEMVER-MINOR) add 'none' style to styleText (James M Snell) #58437 PR-URL: #58665
Fixes: #58088