fs: ensure dir.read() does not throw synchronously
#58228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58228 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.01%
==========================================
Files 629 629
Lines 186641 186641
Branches 36654 36667 +13
==========================================
+ Hits 168329 168353 +24
- Misses 11112 11115 +3
+ Partials 7200 7173 -27
🚀 New features to boost your workflow:
|
LiviaMedeiros
approved these changes
May 8, 2025
LiviaMedeiros
added
author ready
github-actions
bot
removed
the
request-ci
atlowChemi
approved these changes
May 8, 2025
cjihrig
approved these changes
May 8, 2025
lpinca
approved these changes
May 8, 2025
jasnell
reviewed
May 8, 2025
| @@ -188,7 +188,7 @@ async function doAsyncIterThrowTest() { | |||
| } | |||
| } | |||
|
|
|||
| await assert.rejects(async () => dir.read(), dirclosedError); | |||
| await assert.rejects(dir.read(), dirclosedError); | |||
There was a problem hiding this comment.
hmm, the title says dir.close() but the tests are looking at dir.read() with the dirclosedError. Just a bit confusing. Some additional code comments could help
aduh95
changed the title
dir.close() does not throw synchronouslydir.read() does not throw synchronously
aduh95
added a commit
to aduh95/node
that referenced
this pull request
May 10, 2025
PR-URL: nodejs#58228 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: nodejs#58228 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58228 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58228 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the promise version, it should return a rejected Promise, not throw.