-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
deps: update llhttp to 9.3.0 #58144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update llhttp to 9.3.0 #58144
Conversation
Review requested:
|
cc @nodejs/http @nodejs/llhttp |
18ff350
to
71e7ad2
Compare
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE).
71e7ad2
to
d41e8cb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58144 +/- ##
==========================================
- Coverage 90.17% 90.17% -0.01%
==========================================
Files 630 630
Lines 186473 186473
Branches 36613 36614 +1
==========================================
- Hits 168160 168151 -9
+ Misses 11128 11121 -7
- Partials 7185 7201 +16
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Marked as dont-land-on-v20.x because it has llhttp v8. |
Commit Queue failed- Loading data for nodejs/node/pull/58144 ✔ Done loading data for nodejs/node/pull/58144 ----------------------------------- PR info ------------------------------------ Title deps: update llhttp to 9.3.0 (#58144) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch indutny:feature/llhttp-9-3-0 -> nodejs:main Labels lib / src, needs-ci, dont-land-on-v20.x Commits 1 - deps: update llhttp to 9.3.0 Committers 1 - Fedor Indutny <238531+indutny@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 03 May 2025 17:49:33 GMT ✔ Approvals: 4 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813280324 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813281787 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813479866 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813582968 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14842769407 |
Landed in 4454d09 |
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE). PR-URL: #58144 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
llhttp@9.3.0 optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE).