-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
test: skip test-buffer-tostring-rangeerror when low on memory #58142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
BridgeAR:skip-flaky-buffer-rangeerror-when-low-on-memory
May 7, 2025
Merged
test: skip test-buffer-tostring-rangeerror when low on memory #58142
nodejs-github-bot
merged 1 commit into
nodejs:main
from
BridgeAR:skip-flaky-buffer-rangeerror-when-low-on-memory
May 7, 2025
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has shown up as RangeError: Array buffer allocation failed and it should be totally fine to skip this test in case the memory is low.
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14813004228 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58142 +/- ##
==========================================
- Coverage 90.24% 90.17% -0.08%
==========================================
Files 630 630
Lines 185670 186473 +803
Branches 36401 36609 +208
==========================================
+ Hits 167567 168154 +587
- Misses 10992 11119 +127
- Partials 7111 7200 +89 🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 4, 2025
targos
approved these changes
May 4, 2025
LiviaMedeiros
approved these changes
May 4, 2025
StefanStojanovic
approved these changes
May 5, 2025
jasnell
approved these changes
May 6, 2025
Landed in 5f252a4 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
This has shown up as RangeError: Array buffer allocation failed and it should be totally fine to skip this test in case the memory is low. PR-URL: #58142 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has shown up as RangeError: Array buffer allocation failed and it should be totally fine to skip this test in case the memory is low.
https://ci.nodejs.org/job/node-test-binary-windows-js-suites/33969/RUN_SUBSET=2,nodes=win2019-COMPILED_BY-vs2019/console