Skip to content

tools: add read permission to workflows that read contents #58255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 9, 2025

Not having this permission is OK because the repo is public, but on private forks (e.g. the one where security releases are getting prepared), it fails at the checkout step.

Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 9, 2025
@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 10, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 6e222ed into nodejs:main May 11, 2025
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6e222ed

@aduh95 aduh95 deleted the permission-contents-read branch May 12, 2025 05:50
targos pushed a commit that referenced this pull request May 16, 2025
Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.

PR-URL: #58255
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 added a commit that referenced this pull request Jun 10, 2025
Not having this permission is OK because the repo is public, but
on private forks, it fails the checkout step.

PR-URL: #58255
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants