-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
tools: add read permission to workflows that read contents #58255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:permission-contents-read
May 11, 2025
Merged
tools: add read permission to workflows that read contents #58255
nodejs-github-bot
merged 1 commit into
nodejs:main
from
aduh95:permission-contents-read
May 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having this permission is OK because the repo is public, but on private forks, it fails the checkout step.
Review requested:
|
LiviaMedeiros
approved these changes
May 10, 2025
targos
approved these changes
May 10, 2025
benjamingr
approved these changes
May 10, 2025
lpinca
approved these changes
May 10, 2025
bjohansebas
approved these changes
May 11, 2025
RafaelGSS
approved these changes
May 11, 2025
Landed in 6e222ed |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
Not having this permission is OK because the repo is public, but on private forks, it fails the checkout step. PR-URL: #58255 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95
added a commit
that referenced
this pull request
Jun 10, 2025
Not having this permission is OK because the repo is public, but on private forks, it fails the checkout step. PR-URL: #58255 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having this permission is OK because the repo is public, but on private forks (e.g. the one where security releases are getting prepared), it fails at the checkout step.