test: allow tmpDir.path to be modified
#58173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58173 +/- ##
==========================================
- Coverage 90.17% 90.14% -0.03%
==========================================
Files 630 630
Lines 186756 186756
Branches 36664 36648 -16
==========================================
- Hits 168399 168359 -40
- Misses 11179 11183 +4
- Partials 7178 7214 +36 🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 5, 2025
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
May 7, 2025
|
This PR is |
|
It's been seven days, can this land? |
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 563be01 |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58173 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58173 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior was changed in 8e87299, which broke
make test-npm, as it tries modifying the path used for tmpDir.