Skip to content

http2: add diagnostics channel 'http2.client.stream.created' #58246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2025
Merged

http2: add diagnostics channel 'http2.client.stream.created' #58246

merged 2 commits into from
May 11, 2025
+87 −0

Conversation

RaisinTen
Copy link
Member

No description provided.

@RaisinTen
http2: add diagnostics channel 'http2.client.stream.created'
0511b27 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 9, 2025
@RaisinTen RaisinTen mentioned this pull request May 9, 2025
Open
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen requested a review from Qard May 9, 2025 07:07
@codecov Codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (535c2f7) to head (c2e1664).
Report is 63 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58246      +/-   ##
==========================================
+ Coverage   90.12%   90.18%   +0.06%     
==========================================
  Files         629      629              
  Lines      186638   186657      +19     
  Branches    36618    36657      +39     
==========================================
+ Hits       168202   168336     +134     
+ Misses      11222    11125      -97     
+ Partials     7214     7196      -18
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.44% <100.00%> (+0.02%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ShogunPanda
ShogunPanda approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 9, 2025
@RaisinTen
test: assert that the stream constructor name is ClientHttp2Stream
c2e1664 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen
Copy link
Member Author

I pushed a tiny commit to assert that the stream is indeed a ClientHttp2Stream instance by checking the constructor name. Can you review it?

@RaisinTen RaisinTen added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66750/

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5f841fb into nodejs:main May 11, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5f841fb

@RaisinTen RaisinTen deleted the http2-add-diagnostics-channel-http2.client.stream.created branch May 11, 2025 11:16
@RaisinTen RaisinTen added the diagnostics_channel Issues and PRs related to diagnostics channel label May 15, 2025
targos pushed a commit that referenced this pull request May 16, 2025
@RaisinTen @targos
http2: add diagnostics channel 'http2.client.stream.created'
2cb86a3 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58246
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@RaisinTen @aduh95
http2: add diagnostics channel 'http2.client.stream.created'
b99d131 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58246
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@santigimeno santigimeno Awaiting requested review from santigimeno

@ShogunPanda ShogunPanda Awaiting requested review from ShogunPanda

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. diagnostics_channel Issues and PRs related to diagnostics channel http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RaisinTen @nodejs-github-bot @ShogunPanda @Qard @santigimeno