Skip to content

tools: ignore deps and benchmark folder #58254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

RafaelGSS
Copy link
Member

This should solve nodejs/security-wg#1453 (comment)

cc: @nodejs/security-wg

@RafaelGSS RafaelGSS requested a review from richardlau May 9, 2025 22:42
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 9, 2025
@aduh95
Copy link
Contributor

aduh95 commented May 10, 2025

It'd be less confusing to amend the commit message to say it's CodeQL related

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduh95 aduh95 merged commit 0c78a48 into nodejs:main May 15, 2025
17 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 15, 2025

Landed in 0c78a48

targos pushed a commit that referenced this pull request May 16, 2025
PR-URL: #58254
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants