Skip to content

test: remove Float16Array flag #58184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LiviaMedeiros
Copy link
Member

No dont-land-on-v24.x assuming that f75a126 gets included in v24.x

@LiviaMedeiros LiviaMedeiros added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v23.x labels May 5, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 5, 2025
@LiviaMedeiros LiviaMedeiros added the test Issues and PRs related to the tests. label May 5, 2025
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (6102159) to head (2f1f948).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58184      +/-   ##
==========================================
- Coverage   90.15%   90.14%   -0.02%     
==========================================
  Files         630      630              
  Lines      186756   186756              
  Branches    36653    36654       +1     
==========================================
- Hits       168369   168350      -19     
- Misses      11189    11193       +4     
- Partials     7198     7213      +15     

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros force-pushed the test-float16array-bydefault branch from 80fc0e1 to 2f1f948 Compare May 6, 2025 05:59
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2025
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 7, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/58184
✔  Done loading data for nodejs/node/pull/58184
----------------------------------- PR info ------------------------------------
Title      test: remove Float16Array flag (#58184)
Author     Livia Medeiros <livia@cirno.name> (@LiviaMedeiros)
Branch     LiviaMedeiros:test-float16array-bydefault -> nodejs:main
Labels     test, tools, author ready, needs-ci, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x
Commits    2
 - test: remove Float16Array flag
 - tools: recognize `Float16Array` global in linter
Committers 1
 - LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/58184
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58184
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 05 May 2025 17:12:48 GMT
   ✔  Approvals: 4
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/58184#pullrequestreview-2815516668
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/58184#pullrequestreview-2815519466
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58184#pullrequestreview-2819438049
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58184#pullrequestreview-2820025260
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-05-06T07:23:15Z: https://ci.nodejs.org/job/node-test-pull-request/66637/
- Querying data for job/node-test-pull-request/66637/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 58184
From https://github.com/nodejs/node
 * branch                  refs/pull/58184/merge -> FETCH_HEAD
✔  Fetched commits as 5f252a45bc4d..2f1f948ff2da
--------------------------------------------------------------------------------
[main 8834a75158] test: remove Float16Array flag
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Tue May 6 01:01:56 2025 +0800
 5 files changed, 2 insertions(+), 21 deletions(-)
[main 8abf43d725] tools: recognize `Float16Array` global in linter
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Tue May 6 01:02:06 2025 +0800
 1 file changed, 1 insertion(+)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: remove Float16Array flag

PR-URL: #58184
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

[detached HEAD 1792f0d839] test: remove Float16Array flag
Author: LiviaMedeiros <livia@cirno.name>
Date: Tue May 6 01:01:56 2025 +0800
5 files changed, 2 insertions(+), 21 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
tools: recognize Float16Array global in linter

PR-URL: #58184
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

[detached HEAD 5951c904ea] tools: recognize Float16Array global in linter
Author: LiviaMedeiros <livia@cirno.name>
Date: Tue May 6 01:02:06 2025 +0800
1 file changed, 1 insertion(+)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/14889276285

@panva panva added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1350ade into nodejs:main May 7, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1350ade

targos pushed a commit that referenced this pull request May 16, 2025
PR-URL: #58184
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants