-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
test: remove Float16Array flag #58184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove Float16Array flag #58184
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58184 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.02%
==========================================
Files 630 630
Lines 186756 186756
Branches 36653 36654 +1
==========================================
- Hits 168369 168350 -19
- Misses 11189 11193 +4
- Partials 7198 7213 +15 🚀 New features to boost your workflow:
|
80fc0e1
to
2f1f948
Compare
Commit Queue failed- Loading data for nodejs/node/pull/58184 ✔ Done loading data for nodejs/node/pull/58184 ----------------------------------- PR info ------------------------------------ Title test: remove Float16Array flag (#58184) Author Livia Medeiros <livia@cirno.name> (@LiviaMedeiros) Branch LiviaMedeiros:test-float16array-bydefault -> nodejs:main Labels test, tools, author ready, needs-ci, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v23.x Commits 2 - test: remove Float16Array flag - tools: recognize `Float16Array` global in linter Committers 1 - LiviaMedeiros <livia@cirno.name> PR-URL: https://github.com/nodejs/node/pull/58184 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58184 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 05 May 2025 17:12:48 GMT ✔ Approvals: 4 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/58184#pullrequestreview-2815516668 ✔ - Filip Skokan (@panva): https://github.com/nodejs/node/pull/58184#pullrequestreview-2815519466 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58184#pullrequestreview-2819438049 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58184#pullrequestreview-2820025260 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-05-06T07:23:15Z: https://ci.nodejs.org/job/node-test-pull-request/66637/ - Querying data for job/node-test-pull-request/66637/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 58184 From https://github.com/nodejs/node * branch refs/pull/58184/merge -> FETCH_HEAD ✔ Fetched commits as 5f252a45bc4d..2f1f948ff2da -------------------------------------------------------------------------------- [main 8834a75158] test: remove Float16Array flag Author: LiviaMedeiros <livia@cirno.name> Date: Tue May 6 01:01:56 2025 +0800 5 files changed, 2 insertions(+), 21 deletions(-) [main 8abf43d725] tools: recognize `Float16Array` global in linter Author: LiviaMedeiros <livia@cirno.name> Date: Tue May 6 01:02:06 2025 +0800 1 file changed, 1 insertion(+) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- test: remove Float16Array flaghttps://github.com/nodejs/node/actions/runs/14889276285 |
Landed in 1350ade |
PR-URL: #58184 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
No
dont-land-on-v24.x
assuming that f75a126 gets included in v24.x