Skip to content

doc: update return types for eventNames method in EventEmitter #58083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2025
Merged

doc: update return types for eventNames method in EventEmitter #58083

merged 2 commits into from
May 4, 2025

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Apr 30, 2025

Updates the documentation for emitter.eventNames() to clarify that it returns (string | symbol)[].

@nodejs-github-bot nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels Apr 30, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (e61aa0c) to head (1d6474b).
Report is 62 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58083      +/-   ##
==========================================
+ Coverage   89.67%   90.21%   +0.54%     
==========================================
  Files         630      630              
  Lines      186445   186446       +1     
  Branches    36310    36614     +304     
==========================================
+ Hits       167190   168198    +1008     
+ Misses      11998    11049     -949     
+ Partials     7257     7199      -58
Files with missing lines Coverage Δ
lib/events.js 99.75% <100.00%> (+1.56%) ⬆️

... and 100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BridgeAR
BridgeAR approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

LiviaMedeiros
LiviaMedeiros approved these changes May 1, 2025
View reviewed changes
@y-hsgw @LiviaMedeiros
doc: remove comment
1d6474b 
Co-authored-by: Livia Medeiros <livia@cirno.name>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66526/

@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 1, 2025
@atlowChemi atlowChemi changed the title docs: update return types for eventNames method in EventEmitter doc: update return types for eventNames method in EventEmitter May 1, 2025
@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit 6de55f7 into nodejs:main May 4, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6de55f7

@y-hsgw y-hsgw deleted the docs/events-emitter-event-names branch May 4, 2025 14:39
targos pushed a commit that referenced this pull request May 16, 2025
@y-hsgw @targos
doc: update return types for eventNames method in EventEmitter
62dbd36 
PR-URL: #58083
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@y-hsgw @aduh95
doc: update return types for eventNames method in EventEmitter
34a9b85 
PR-URL: #58083
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@Flarna Flarna Flarna approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@y-hsgw @nodejs-github-bot @lpinca @anonrig @BridgeAR @Flarna @atlowChemi @LiviaMedeiros