Skip to content

http2: add diagnostics channel 'http2.client.stream.start' #58292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

http2: add diagnostics channel 'http2.client.stream.start' #58292

merged 1 commit into from
May 14, 2025

Conversation

RaisinTen
Copy link
Member

No description provided.

@RaisinTen
http2: add diagnostics channel 'http2.client.stream.start'
79695a2 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels May 12, 2025
@RaisinTen RaisinTen mentioned this pull request May 12, 2025
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66771/

@codecov Codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (6184730) to head (79695a2).
Report is 32 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58292   +/-   ##
=======================================
  Coverage   90.18%   90.19%           
=======================================
  Files         631      631           
  Lines      186690   186703   +13     
  Branches    36666    36663    -3     
=======================================
+ Hits       168360   168388   +28     
+ Misses      11126    11125    -1     
+ Partials     7204     7190   -14
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.46% <100.00%> (+0.01%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RaisinTen RaisinTen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 13, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit b197355 into nodejs:main May 14, 2025
69 of 70 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b197355

@RaisinTen RaisinTen deleted the http2-add-diagnostics-channel-http2.client.stream.start branch May 14, 2025 07:46
@RaisinTen RaisinTen added the diagnostics_channel Issues and PRs related to diagnostics channel label May 15, 2025
targos pushed a commit that referenced this pull request May 16, 2025
@RaisinTen @targos
http2: add diagnostics channel 'http2.client.stream.start'
24a9aef 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58292
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@github-actions github-actions bot mentioned this pull request May 20, 2025
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@RaisinTen @aduh95
http2: add diagnostics channel 'http2.client.stream.start'
6c3e426 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #58292
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@santigimeno santigimeno santigimeno approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaisinTen @nodejs-github-bot @jasnell @santigimeno