-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
workers: make Worker async disposable #58385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jasnell
commented
May 19, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58385 +/- ##
==========================================
- Coverage 90.20% 90.19% -0.02%
==========================================
Files 635 635
Lines 187224 187229 +5
Branches 36770 36774 +4
==========================================
- Hits 168889 168862 -27
- Misses 11088 11124 +36
+ Partials 7247 7243 -4
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with or without the nit; and s/^workers/worker/
in the commit message.
Noting that the code change can be safely backported to release lines that have Symbol.asyncDispose
but not the ERM itself; and splitting this into two commits (one that adds [SymbolAsyncDispose]()
, tests it by calling explicitly, and documents without code example; and another for v24+ adding using
in tests in docs) might make it more straightforward for releasers.
Why
dont-land-on-v22.x
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
658a86f
to
9e53faf
Compare
9e53faf
to
102558e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
PR-URL: #58385 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #58385 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Landed in 62855f3...d968227 |
Manual Backport of nodejs#58385 Original metadata: PR-URL: nodejs#58385 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>