Skip to content

Commit 8bc0452

Browse files
dario-piotrowicztargos
authored andcommitted
benchmark: fix broken fs.cpSync benchmark
PR-URL: #58472 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 21f6400 commit 8bc0452

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

benchmark/fs/bench-cpSync.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ const tmpdir = require('../../test/common/tmpdir');
88
const bench = common.createBenchmark(main, {
99
n: [1, 100, 10_000],
1010
dereference: ['true', 'false'],
11-
force: ['true', 'false'],
11+
// When `force` is `true` the `cpSync` function is called twice the second
12+
// time however an `ERR_FS_CP_EINVAL` is thrown, so skip `true` for the time being
13+
// TODO: allow `force` to also be `true` once https://github.com/nodejs/node/issues/58468 is addressed
14+
force: ['false'],
1215
});
1316

1417
function prepareTestDirectory() {

0 commit comments

Comments
 (0)