test: remove --no-warnings flag #58424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should have no effect since the test does not appear to emit any warnings. If there are warnings, we probably should handle them properly instead of passing this flag to the runtime. Refs: nodejs#35093
tniessen
added
crypto
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58424 +/- ##
==========================================
+ Coverage 90.21% 90.22% +0.01%
==========================================
Files 635 635
Lines 187171 187174 +3
Branches 36748 36750 +2
==========================================
+ Hits 168851 168879 +28
+ Misses 11069 11063 -6
+ Partials 7251 7232 -19 🚀 New features to boost your workflow:
|
juanarbol
approved these changes
May 22, 2025
jasnell
approved these changes
May 22, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
May 23, 2025
|
CI failed in a OpenSSL 1.1.1 FIPS configuration, but it seems infrastructure related:
|
bjohansebas
approved these changes
May 25, 2025
panva
approved these changes
May 27, 2025
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in affec48 |
targos
pushed a commit
that referenced
this pull request
May 31, 2025
This change should have no effect since the test does not appear to emit any warnings. If there are warnings, we probably should handle them properly instead of passing this flag to the runtime. Refs: #35093 PR-URL: #58424 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should have no effect since the test does not appear to emit any warnings. If there are warnings, we probably should handle them properly instead of passing this flag to the runtime.
Refs: #35093