Skip to content

build,win: fix dll build #58357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

StefanStojanovic
Copy link
Contributor

@StefanStojanovic StefanStojanovic commented May 16, 2025

Fixes a linker error when building Node.js DLL with ClangCL by moving BuiltinLoader::GetBuiltinIds() implementation from .h to .cc file.

This PR tries different approach from #58235 based on @joyeecheung's comment

Fixes: #58208

@StefanStojanovic StefanStojanovic added c++ Issues and PRs that require attention from people who are familiar with C++. windows Issues and PRs related to the Windows platform. labels May 16, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 16, 2025
@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (7622f0d) to head (d9a13d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58357      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files         635      635              
  Lines      187632   187632              
  Branches    36857    36855       -2     
==========================================
+ Hits       169303   169326      +23     
+ Misses      11094    11081      -13     
+ Partials     7235     7225      -10     
Files with missing lines Coverage Δ
src/node_builtins.cc 79.51% <100.00%> (+0.34%) ⬆️
src/node_builtins.h 100.00% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@StefanStojanovic StefanStojanovic force-pushed the mefi-dll-fix2 branch 4 times, most recently from ac0aac4 to fa05828 Compare May 30, 2025 12:00
@legendecas legendecas added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build libnode v24.0.0 on Windows
4 participants