-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
build,win: fix dll build #58357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StefanStojanovic
wants to merge
2
commits into
nodejs:main
Choose a base branch
from
JaneaSystems:mefi-dll-fix2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
build,win: fix dll build #58357
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
anonrig
approved these changes
May 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58357 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 635 635
Lines 187632 187632
Branches 36857 36855 -2
==========================================
+ Hits 169303 169326 +23
+ Misses 11094 11081 -13
+ Partials 7235 7225 -10
🚀 New features to boost your workflow:
|
legendecas
reviewed
May 20, 2025
ac0aac4
to
fa05828
Compare
fa05828
to
d9a13d6
Compare
legendecas
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
needs-ci
PRs that need a full CI run.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a linker error when building Node.js DLL with ClangCL by moving
BuiltinLoader::GetBuiltinIds()
implementation from.h
to.cc
file.This PR tries different approach from #58235 based on @joyeecheung's comment
Fixes: #58208