zlib: remove mentions of unexposed Z_TREES constant #58371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Z_TREES` is never exposed on `DefineZlibConstants()`, hence it shall be removed. This fix is applicable to v18+. Refs: https://github.com/nodejs/node/blob/main/src/node_zlib.cc
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58371 +/- ##
==========================================
- Coverage 90.24% 90.23% -0.01%
==========================================
Files 633 633
Lines 186860 186860
Branches 36675 36684 +9
==========================================
- Hits 168623 168615 -8
- Misses 11035 11047 +12
+ Partials 7202 7198 -4
🚀 New features to boost your workflow:
|
anonrig
approved these changes
May 17, 2025
github-actions
bot
removed
the
request-ci
|
Not sure why test fails. The report in https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel8-s390x/49510/testReport/junit/(root)/parallel/test_http2_debug/ does not tell me much. Would reviewers want to take a look on this? |
lpinca
approved these changes
May 18, 2025
It is a known flake. Refs: #58353 |
github-actions
bot
removed
the
request-ci
addaleax
approved these changes
May 19, 2025
bjohansebas
approved these changes
May 26, 2025
bjohansebas
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58371 ✔ Done loading data for nodejs/node/pull/58371 ----------------------------------- PR info ------------------------------------ Title zlib: remove mentions of unexposed Z_TREES constant (#58371) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch hkleungai:zlib-remove-mentions-of-constants.Z_TREES -> nodejs:main Labels zlib, needs-ci Commits 1 - zlib: remove mentions of unexposed Z_TREES constant Committers 1 - Jimmy Leung <43258070+hkleungai@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/58371 Refs: https://github.com/nodejs/node/blob/main/src/node_zlib.cc Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58371 Refs: https://github.com/nodejs/node/blob/main/src/node_zlib.cc Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 17 May 2025 18:47:10 GMT ✔ Approvals: 4 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58371#pullrequestreview-2848438287 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58371#pullrequestreview-2848549721 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58371#pullrequestreview-2848916852 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/58371#pullrequestreview-2851541959 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-05-18T16:58:52Z: https://ci.nodejs.org/job/node-test-pull-request/66899/ - Querying data for job/node-test-pull-request/66899/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15243969971 |
bjohansebas
added
request-ci
github-actions
bot
removed
the
request-ci
bjohansebas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c969649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Z_TREESis never exposed onDefineZlibConstants(), hence it shall beremoved.
This fix is applicable to v18+.
Refs: https://github.com/nodejs/node/blob/main/src/node_zlib.cc